Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: ash/common/system/tray/actionable_view.h

Issue 2499453002: Add ink drop ripple to overview mode button (Closed)
Patch Set: Fixed crash when there is no window Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/system/tray/actionable_view.h
diff --git a/ash/common/system/tray/actionable_view.h b/ash/common/system/tray/actionable_view.h
index 1dd60b4b41b68d3e63f6cf764c9ad286868baf64..bd074d39008f13b2957b34447731c39744f2b180 100644
--- a/ash/common/system/tray/actionable_view.h
+++ b/ash/common/system/tray/actionable_view.h
@@ -52,6 +52,13 @@ class ASH_EXPORT ActionableView : public views::ButtonListener,
// been handled and an action was performed. Returns false otherwise.
virtual bool PerformAction(const ui::Event& event) = 0;
+ // Called after PerformAction() to act upon its result, including showing
+ // appropriate ink drop ripple. By default shows triggered ripple if action is
+ // performed or hides existing ripple if no action is performed. Subclassed
+ // can override to change the default behavior.
bruthig 2016/11/11 17:30:40 nit: Can you also note that this will not be calle
mohsen 2016/11/11 22:37:24 Done.
+ virtual void HandlePerformActionResult(bool action_performed,
+ const ui::Event& event);
+
// Overridden from views::CustomButton.
const char* GetClassName() const override;
bool OnKeyPressed(const ui::KeyEvent& event) override;

Powered by Google App Engine
This is Rietveld 408576698