Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2168)

Unified Diff: ash/common/wm/overview/window_selector_controller.cc

Issue 2499453002: Add ink drop ripple to overview mode button (Closed)
Patch Set: Rebased Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/wm/overview/window_selector_controller.cc
diff --git a/ash/common/wm/overview/window_selector_controller.cc b/ash/common/wm/overview/window_selector_controller.cc
index 17810f1779e306d2460ce4a46f6a73c1a76f56ef..76ef5d0bfbb4a9fdd68b3e51c49cb84cee28d5ce 100644
--- a/ash/common/wm/overview/window_selector_controller.cc
+++ b/ash/common/wm/overview/window_selector_controller.cc
@@ -42,13 +42,13 @@ bool WindowSelectorController::CanSelect() {
LoginStatus::KIOSK_APP;
}
-void WindowSelectorController::ToggleOverview() {
+bool WindowSelectorController::ToggleOverview() {
if (IsSelecting()) {
OnSelectionEnded();
} else {
// Don't start overview if window selection is not allowed.
if (!CanSelect())
- return;
+ return false;
std::vector<WmWindow*> windows =
WmShell::Get()->mru_window_tracker()->BuildMruWindowList();
@@ -59,13 +59,14 @@ void WindowSelectorController::ToggleOverview() {
// Don't enter overview mode with no windows.
if (windows.empty())
- return;
+ return false;
WmShell::Get()->OnOverviewModeStarting();
window_selector_.reset(new WindowSelector(this));
window_selector_->Init(windows);
OnSelectionStarted();
}
+ return true;
}
bool WindowSelectorController::IsSelecting() const {
« no previous file with comments | « ash/common/wm/overview/window_selector_controller.h ('k') | ash/system/overview/overview_button_tray_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698