Add ink drop ripple to overview mode button

ui/views/animation/ink_drop_impl_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 
 #include "ui/views/animation/ink_drop_impl.h"
 
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/test/test_simple_task_runner.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "testing/gtest/include/gtest/gtest.h"
+#include "ui/compositor/scoped_animation_duration_scale_mode.h"
 #include "ui/views/animation/test/ink_drop_impl_test_api.h"
 #include "ui/views/animation/test/test_ink_drop_host.h"
 
 namespace views {
 
 // NOTE: The InkDropImpl class is also tested by the InkDropFactoryTest tests.
 class InkDropImplTest : public testing::Test {
  public:
   InkDropImplTest();
   ~InkDropImplTest() override;
 
  protected:
   TestInkDropHost* ink_drop_host() { return ink_drop_host_.get(); }
 
   InkDropImpl* ink_drop() { return ink_drop_.get(); }
 
   test::InkDropImplTestApi* test_api() { return test_api_.get(); }
 
   // Runs all the pending tasks in |task_runner_|. This can be used to progress
   // timers. e.g. HideHighlightOnRippleHiddenState's
   // |highlight_after_ripple_timer_|.
   void RunPendingTasks();
 
   // Returns true if the ink drop layers have been added to |ink_drop_host_|.
   bool AreLayersAddedToHost() const;
 
-  // Destroyes the |ink_drop_| and assocated |test_api_|.
+  // Destroys the |ink_drop_| and associated |test_api_|.
   void DestroyInkDrop();
 
   // Used to control the tasks scheduled by the InkDropImpl's Timer.
   scoped_refptr<base::TestSimpleTaskRunner> task_runner_;
 
   // Required by base::Timer's.
   std::unique_ptr<base::ThreadTaskRunnerHandle> thread_task_runner_handle_;
 
  private:
   std::unique_ptr<TestInkDropHost> ink_drop_host_;
@@ skipping 192 matching lines @@
 
 // Verifies there is no use after free errors.
 TEST_F(InkDropImplTest,
        TearingDownHighlightStateThatAccessesTheStateFactoryIsSafe) {
   test::InkDropImplTestApi::AccessFactoryOnExitHighlightState::Install(
       test_api()->state_factory());
   test::InkDropImplTestApi::AccessFactoryOnExitHighlightState::Install(
       test_api()->state_factory());
 }
 
+// Tests that if during destruction, a rippl animation is successfully ended, no
+// crash happens (see https://crbug.com/663579).
+TEST_F(InkDropImplTest, SuccessfulAnimationEndedDuringDestruction) {
+  // Start a ripple animation with non-zero duration.
+  ink_drop()->AnimateToState(InkDropState::ACTION_PENDING);
+  {
+    // Start another ripple animation with zero duration that would be queued
+    // until the previous one is finished/aborted.
+    ui::ScopedAnimationDurationScaleMode duration_mode(
+        ui::ScopedAnimationDurationScaleMode::ZERO_DURATION);
+    ink_drop()->AnimateToState(InkDropState::ACTION_TRIGGERED);
+  }
+  // Abort the first animation, so that the queued animation is started (and
+  // finished immediately since it has zero duration). No crash should happen.
+  DestroyInkDrop();
+}
+
 ////////////////////////////////////////////////////////////////////////////////
 //
 // Common AutoHighlightMode tests
 //
 
 typedef InkDropImplAutoHighlightTest InkDropImplCommonAutoHighlightTest;
 // Note: First argument is optional and intentionally left blank.
 // (it's a prefix for the generated test cases)
 INSTANTIATE_TEST_CASE_P(
     ,
@@ skipping 273 matching lines @@
   EXPECT_TRUE(test_api()->IsHighlightFadingInOrVisible());
 
   ink_drop()->SetHovered(false);
   ink_drop()->SetFocused(false);
 
   EXPECT_TRUE(test_api()->IsHighlightFadingInOrVisible());
   EXPECT_FALSE(test_api()->ShouldHighlight());
 }
 
 }  // namespace views