Add ink drop ripple to overview mode button

ash/common/system/tray/tray_background_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_COMMON_SYSTEM_TRAY_TRAY_BACKGROUND_VIEW_H_
 #define ASH_COMMON_SYSTEM_TRAY_TRAY_BACKGROUND_VIEW_H_
 
 #include <memory>
 
 #include "ash/ash_export.h"
@@ skipping 60 matching lines @@
 
   // views::View:
   void SetVisible(bool visible) override;
   const char* GetClassName() const override;
   void ChildPreferredSizeChanged(views::View* child) override;
   void GetAccessibleNodeData(ui::AXNodeData* node_data) override;
   void AboutToRequestFocusFromTabTraversal(bool reverse) override;
   void OnPaint(gfx::Canvas* canvas) override;
 
   // ActionableView:
+  std::unique_ptr<views::InkDropRipple> CreateInkDropRipple() const override;
+  std::unique_ptr<views::InkDropHighlight> CreateInkDropHighlight()
+      const override;
+  bool ShouldEnterPushedState(const ui::Event& event) override;
   bool PerformAction(const ui::Event& event) override;
+  void HandlePerformActionResult(bool action_performed,
+                                 const ui::Event& event) override;
   gfx::Rect GetFocusBounds() override;
   void OnGestureEvent(ui::GestureEvent* event) override;
 
   // Called whenever the shelf alignment changes.
   virtual void SetShelfAlignment(ShelfAlignment alignment);
 
   // Called when the anchor (tray or bubble) may have moved or changed.
   virtual void AnchorUpdated() {}
 
   // Called from GetAccessibleNodeData, must return a valid accessible name.
   virtual base::string16 GetAccessibleNameForTray() = 0;
 
   // Called when the bubble is resized.
   virtual void BubbleResized(const views::TrayBubbleView* bubble_view) {}
 
   // Hides the bubble associated with |bubble_view|. Called when the widget
   // is closed.
   virtual void HideBubbleWithView(const views::TrayBubbleView* bubble_view) = 0;
 
   // Called by the bubble wrapper when a click event occurs outside the bubble.
   // May close the bubble.
   virtual void ClickedOutsideBubble() = 0;
 
   // Sets |contents| as a child.
   void SetContents(views::View* contents);
 
-  // Creates and sets contents background to |background_|.
-  void SetContentsBackground();
+  // Creates and sets contents background to |background_|. |draws_active|
+  // determines if the view needs its active background drawn.

[tdanderson, 2016/11/12 02:18:58]

nit: I think a clearer wording would be "|draws_active| determines if the view's
background should be drawn as active when the view is in the active state" or
similar

[mohsen, 2016/11/13 05:10:04]

Done.

+  void SetContentsBackground(bool draws_active);
 
   // Returns the anchor rect for the bubble.
   gfx::Rect GetBubbleAnchorRect(
       views::Widget* anchor_widget,
       views::TrayBubbleView::AnchorType anchor_type,
       views::TrayBubbleView::AnchorAlignment anchor_alignment) const;
 
   // Returns the bubble anchor alignment based on |shelf_alignment_|.
   views::TrayBubbleView::AnchorAlignment GetAnchorAlignment() const;
 
-  // Forces the background to be drawn active if set to true.
-  void SetDrawBackgroundAsActive(bool visible);
-
-  // Returns true when the the background was overridden to be drawn as active.
-  bool draw_background_as_active() const { return draw_background_as_active_; }
+  void SetIsActive(bool is_active);
+  bool is_active() const { return is_active_; }
 
   TrayContainer* tray_container() const { return tray_container_; }
   ShelfAlignment shelf_alignment() const { return shelf_alignment_; }
   TrayEventFilter* tray_event_filter() { return tray_event_filter_.get(); }
   WmShelf* shelf() { return wm_shelf_; }
 
   // Updates the arrow visibility based on the launcher visibility.
   void UpdateBubbleViewArrow(views::TrayBubbleView* bubble_view);
 
   // ShelfBackgroundAnimatorObserver:
@@ skipping 19 matching lines @@
   // Convenience pointer to the contents view.
   TrayContainer* tray_container_;
 
   // Shelf alignment.
   // TODO(jamescook): Don't cache this, get it from WmShelf.
   ShelfAlignment shelf_alignment_;
 
   // Owned by the view passed to SetContents().
   TrayBackground* background_;
 
-  // This variable stores the activation override which will tint the background
-  // differently if set to true.
-  bool draw_background_as_active_;
+  // Determines if the view is active. This changes how the background is drawn
+  // in non-MD version and how the ink drop ripples behave in MD version.
+  bool is_active_;
 
   // Visibility of this tray's separator which is a line of 1x32px and 4px to
   // right of tray.
   bool is_separator_visible_;
 
   std::unique_ptr<TrayWidgetObserver> widget_observer_;
   std::unique_ptr<TrayEventFilter> tray_event_filter_;
 
   DISALLOW_COPY_AND_ASSIGN(TrayBackgroundView);
 };
 
 }  // namespace ash
 
 #endif  // ASH_COMMON_SYSTEM_TRAY_TRAY_BACKGROUND_VIEW_H_