Add ink drop ripple to overview mode button

ash/common/system/overview/overview_button_tray.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/system/overview/overview_button_tray.h"
 
 #include "ash/common/material_design/material_design_controller.h"
 #include "ash/common/session/session_state_delegate.h"
 #include "ash/common/shelf/shelf_constants.h"
 #include "ash/common/shelf/wm_shelf_util.h"
@@ skipping 21 matching lines @@
 const int kHorizontalShelfVerticalPadding = 4;
 const int kVerticalShelfHorizontalPadding = 2;
 const int kVerticalShelfVerticalPadding = 5;
 
 }  // namespace
 
 namespace ash {
 
 OverviewButtonTray::OverviewButtonTray(WmShelf* wm_shelf)
     : TrayBackgroundView(wm_shelf), icon_(nullptr) {
-  SetContentsBackground();
-
   icon_ = new views::ImageView();
   if (MaterialDesignController::IsShelfMaterial()) {
+    SetInkDropMode(InkDropMode::ON);
+    SetContentsBackground(false);
     gfx::ImageSkia image_md =
         CreateVectorIcon(gfx::VectorIconId::SHELF_OVERVIEW, kShelfIconColor);
     icon_->SetImage(image_md);
   } else {
+    SetContentsBackground(true);
     gfx::ImageSkia* image_non_md =
         ui::ResourceBundle::GetSharedInstance().GetImageSkiaNamed(
             IDR_AURA_UBER_TRAY_OVERVIEW_MODE);
     icon_->SetImage(image_non_md);
   }
   SetIconBorderForShelfAlignment();
   tray_container()->AddChildView(icon_);
 
   WmShell::Get()->AddShellObserver(this);
   WmShell::Get()->GetSessionStateDelegate()->AddSessionStateObserver(this);
 }
 
 OverviewButtonTray::~OverviewButtonTray() {
   WmShell::Get()->RemoveShellObserver(this);
   WmShell::Get()->GetSessionStateDelegate()->RemoveSessionStateObserver(this);
 }
 
 void OverviewButtonTray::UpdateAfterLoginStatusChange(LoginStatus status) {
   UpdateIconVisibility();
 }
 
 bool OverviewButtonTray::PerformAction(const ui::Event& event) {
   WindowSelectorController* controller =
       WmShell::Get()->window_selector_controller();
+  bool was_selecting = controller->IsSelecting();
   controller->ToggleOverview();

[bruthig, 2016/11/11 17:30:40]

nit: Consider changing ToggleOverview() to return a bool to let the caller know
if a Toggle happened.

[mohsen, 2016/11/11 22:37:24]

Done.

-  SetDrawBackgroundAsActive(controller->IsSelecting());
   WmShell::Get()->RecordUserMetricsAction(UMA_TRAY_OVERVIEW);
-  return true;
+  return was_selecting != controller->IsSelecting();

[bruthig, 2016/11/11 17:30:40]

nit: it would be useful to have a comment here as to when this can be false.

[mohsen, 2016/11/11 22:37:24]

Done.

 }
 
 void OverviewButtonTray::SessionStateChanged(
     session_manager::SessionState state) {
   UpdateIconVisibility();
 }
 
 void OverviewButtonTray::OnMaximizeModeStarted() {
   UpdateIconVisibility();
 }
 
 void OverviewButtonTray::OnMaximizeModeEnded() {
   UpdateIconVisibility();
 }
 
+void OverviewButtonTray::OnOverviewModeStarting() {
+  SetIsActive(true);
+}
+
 void OverviewButtonTray::OnOverviewModeEnded() {
-  SetDrawBackgroundAsActive(false);
+  SetIsActive(false);
 }
 
 void OverviewButtonTray::ClickedOutsideBubble() {}
 
 base::string16 OverviewButtonTray::GetAccessibleNameForTray() {
   return l10n_util::GetStringUTF16(IDS_ASH_OVERVIEW_BUTTON_ACCESSIBLE_NAME);
 }
 
 void OverviewButtonTray::HideBubbleWithView(
     const views::TrayBubbleView* bubble_view) {
@@ skipping 39 matching lines @@
       shell->maximize_mode_controller()->IsMaximizeModeWindowManagerEnabled() &&
       session_state_delegate->IsActiveUserSessionStarted() &&
       !session_state_delegate->IsScreenLocked() &&
       session_state_delegate->GetSessionState() ==
           session_manager::SessionState::ACTIVE &&
       shell->system_tray_delegate()->GetUserLoginStatus() !=
           LoginStatus::KIOSK_APP);
 }
 
 }  // namespace ash