disable ETC1 on ANGLE's ES3

disable ETC1 on ANGLE's ES3

BUG=658929
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/e4306f9b2ca2daba39c463f5aa54a7a931593a50
Cr-Commit-Position: refs/heads/master@{#432655}

[Kai Ninomiya, 2016-11-15 23:15:13]

Description was changed from

==========
disable ETC1 on ANGLE's ES3

DO NOT COMMIT: this actually disables ETC1 on native ES2 implementations as well

COMMIT=false
BUG=658929
==========

to

==========
disable ETC1 on ANGLE's ES3

DO NOT COMMIT: this actually disables ETC1 on native ES2 implementations as well

COMMIT=false
BUG=658929
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2016-11-16 01:46:31]

Description was changed from

==========
disable ETC1 on ANGLE's ES3

DO NOT COMMIT: this actually disables ETC1 on native ES2 implementations as well

COMMIT=false
BUG=658929
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
disable ETC1 on ANGLE's ES3

DO NOT COMMIT: this actually disables ETC1 on native ES2 implementations as well

Fix this by doing:
(WEBGL1 && GL_OES_compressed_ETC1_RGB8_texture) ||
GL_CHROMIUM_compressed_texture_etc

COMMIT=false
BUG=658929
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2016-11-16 01:47:04]

Description was changed from

==========
disable ETC1 on ANGLE's ES3

DO NOT COMMIT: this actually disables ETC1 on native ES2 implementations as well

Fix this by doing:
(WEBGL1 && GL_OES_compressed_ETC1_RGB8_texture) ||
GL_CHROMIUM_compressed_texture_etc

COMMIT=false
BUG=658929
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
disable ETC1 on ANGLE's ES3

DO NOT COMMIT: this actually disables ETC1 on native ES2 implementations as well

Fix this by doing:
(WEBGL1 || GL_CHROMIUM_compressed_texture_etc) &&
GL_OES_compressed_ETC1_RGB8_texture

COMMIT=false
BUG=658929
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2016-11-16 06:16:06]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 06:16:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Kai Ninomiya, 2016-11-16 07:19:49]

Description was changed from

==========
disable ETC1 on ANGLE's ES3

DO NOT COMMIT: this actually disables ETC1 on native ES2 implementations as well

Fix this by doing:
(WEBGL1 || GL_CHROMIUM_compressed_texture_etc) &&
GL_OES_compressed_ETC1_RGB8_texture

COMMIT=false
BUG=658929
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
disable ETC1 on ANGLE's ES3

BUG=658929
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2016-11-16 07:21:41]

kainino@chromium.org changed reviewers:
+ kbr@chromium.org, zmo@chromium.org

[Kai Ninomiya, 2016-11-16 07:21:41]

PTAL

Pretty sure I got this logic correct.

[commit-bot: I haz the power, 2016-11-16 08:30:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 08:30:44]

Dry run: Try jobs failed on following builders:
  win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[Zhenyao Mo, 2016-11-16 15:35:37]

On 2016/11/16 07:21:41, Kai Ninomiya wrote:
> PTAL
> 
> Pretty sure I got this logic correct.

You need to update the windows extension expectations.

[Ken Russell (switch to Gerrit), 2016-11-16 17:04:51]

On 2016/11/16 15:35:37, Zhenyao Mo wrote:
> On 2016/11/16 07:21:41, Kai Ninomiya wrote:
> > PTAL
> > 
> > Pretty sure I got this logic correct.
> 
> You need to update the windows extension expectations.

To save time: you'll need to expand the Skip entry for
WebglExtension_WEBGL_compressed_texture_etc1 in
src/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py . (Not
webgl_conformance_expectations.py)

LGTM once that's done.

[Kai Ninomiya, 2016-11-16 17:49:51]

The CQ bit was checked by kainino@chromium.org

[Kai Ninomiya, 2016-11-16 17:49:52]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2499413003/#ps40001
(title: "update expectations")

[commit-bot: I haz the power, 2016-11-16 17:50:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 20:34:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 20:34:38]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Zhenyao Mo, 2016-11-16 21:33:53]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2016-11-16 21:34:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 22:51:03]

Description was changed from

==========
disable ETC1 on ANGLE's ES3

BUG=658929
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
disable ETC1 on ANGLE's ES3

BUG=658929
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-11-16 22:51:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-16 22:53:32]

Description was changed from

==========
disable ETC1 on ANGLE's ES3

BUG=658929
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
disable ETC1 on ANGLE's ES3

BUG=658929
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/e4306f9b2ca2daba39c463f5aa54a7a931593a50
Cr-Commit-Position: refs/heads/master@{#432655}
==========

[commit-bot: I haz the power, 2016-11-16 22:53:33]

Patchset 3 (id:??) landed as
https://crrev.com/e4306f9b2ca2daba39c463f5aa54a7a931593a50
Cr-Commit-Position: refs/heads/master@{#432655}