Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: chrome/chrome_exe.gypi

Issue 24994002: Don't pull in content_switches.cc to whole chrome code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/chrome_installer_util.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_exe.gypi
diff --git a/chrome/chrome_exe.gypi b/chrome/chrome_exe.gypi
index ae000d7dc7f159042e1860b4a3f50bdd0e39e1b9..7fb9a0ffa7fcd72c6b1dc4de9b02abbf10b49c99 100644
--- a/chrome/chrome_exe.gypi
+++ b/chrome/chrome_exe.gypi
@@ -26,7 +26,9 @@
'app/hard_error_handler_win.h',
'app/metro_driver_win.cc',
'app/metro_driver_win.h',
- '../content/app/startup_helper_win.cc',
+ '<(DEPTH)/content/app/startup_helper_win.cc',
+ '<(DEPTH)/content/public/common/content_switches.cc',
+ '<(DEPTH)/content/public/common/content_switches.h',
jam 2013/09/27 20:03:58 nit: drop the header, no need since it's included
Rafał Chłodnicki 2013/09/28 10:05:47 What do you mean that it's included elsewhere? I t
jam 2013/10/01 16:13:19 I mean content_switches.h is by definition include
],
'mac_bundle_resources': [
'app/app-Info.plist',
@@ -567,7 +569,6 @@
'../content/app/startup_helper_win.cc',
'../content/common/sandbox_init_win.cc',
'../content/common/sandbox_win.cc',
- '../content/public/common/content_switches.cc',
'<(SHARED_INTERMEDIATE_DIR)/chrome_version/nacl64_exe_version.rc',
],
'dependencies': [
« no previous file with comments | « no previous file | chrome/chrome_installer_util.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698