Implementation for feature policy - fullscreen

third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/feature_policy/FeaturePolicy.h"
 
 #include "platform/json/JSONValues.h"
 #include "platform/network/HTTPParsers.h"
 #include "platform/weborigin/KURL.h"
 #include "platform/weborigin/SecurityOrigin.h"
@@ skipping 81 matching lines @@
 
 }  // namespace
 
 // Definitions of all features controlled by Feature Policy should appear here.
 const FeaturePolicy::Feature kDocumentCookie{
     "cookie", FeaturePolicy::FeatureDefault::EnableForAll};
 const FeaturePolicy::Feature kDocumentDomain{
     "domain", FeaturePolicy::FeatureDefault::EnableForAll};
 const FeaturePolicy::Feature kDocumentWrite{
     "docwrite", FeaturePolicy::FeatureDefault::EnableForAll};
+const FeaturePolicy::Feature kFullscreenFeature{
+    "fullscreen", FeaturePolicy::FeatureDefault::EnableForAll};

[iclelland, 2016/12/05 16:27:35]

I think this should be EnableForSelf, to closely match the existing behaviour of
fullscreen (where you have to explicitly allow it for frames)

That also makes me think that we need one more test, without an explicit feature
policy, to test what happens in that case. It should essentially be exactly the
same as the 'allowforself' test, without the HTTP header.

[lunalu1, 2016/12/05 20:09:12]

Done.

 const FeaturePolicy::Feature kGeolocationFeature{
     "geolocation", FeaturePolicy::FeatureDefault::EnableForSelf};
 const FeaturePolicy::Feature kMidiFeature{
     "midi", FeaturePolicy::FeatureDefault::EnableForAll};
 const FeaturePolicy::Feature kNotificationsFeature{
     "notifications", FeaturePolicy::FeatureDefault::EnableForAll};
 const FeaturePolicy::Feature kPaymentFeature{
     "payment", FeaturePolicy::FeatureDefault::EnableForSelf};
 const FeaturePolicy::Feature kPushFeature{
     "push", FeaturePolicy::FeatureDefault::EnableForAll};
@@ skipping 43 matching lines @@
   }
   sb.append("]");
   return sb.toString();
 }
 
 // static
 const FeaturePolicy::FeatureList& FeaturePolicy::getDefaultFeatureList() {
   DEFINE_STATIC_LOCAL(
       Vector<const FeaturePolicy::Feature*>, defaultFeatureList,
       ({&kDocumentCookie, &kDocumentDomain, &kDocumentWrite,
-        &kGeolocationFeature, &kMidiFeature, &kNotificationsFeature,
-        &kPaymentFeature, &kPushFeature, &kSyncScript, &kSyncXHR, &kUsermedia,
-        &kVibrateFeature, &kWebRTC}));
+        &kGeolocationFeature, &kFullscreenFeature, &kMidiFeature,
+        &kNotificationsFeature, &kPaymentFeature, &kPushFeature, &kSyncScript,
+        &kSyncXHR, &kUsermedia, &kVibrateFeature, &kWebRTC}));
   return defaultFeatureList;
 }
 
 // static
 std::unique_ptr<FeaturePolicy> FeaturePolicy::createFromParentPolicy(
     const FeaturePolicy* parent,
     RefPtr<SecurityOrigin> currentOrigin,
     FeaturePolicy::FeatureList& features) {
   DCHECK(currentOrigin);
   std::unique_ptr<FeaturePolicy> newPolicy =
@@ skipping 80 matching lines @@
     sb.append("  ");
     sb.append(whitelist.key->featureName);
     sb.append(": ");
     sb.append(whitelist.value->toString());
     sb.append("\n");
   }
   return sb.toString();
 }
 
 }  // namespace blink