third_party/WebKit/LayoutTests/http/tests/feature-policy/fullscreen-enabledforself-expected.txt - Issue 2499373002: Implementation for feature policy - fullscreen

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/feature-policy/fullscreen-enabledforself-expected.txt

Issue 2499373002: Implementation for feature policy - fullscreen (Closed)

Patch Set: Codereview update and added layout tests Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 This is a testharness.js-based test.

	2 PASS Fullscreen enabled for self on URL: resources/feature-policy-fullscreen.htm l with allowfullscreen = false

	3 PASS Fullscreen enabled for self on URL: http://localhost:8000/feature-policy/re sources/feature-policy-fullscreen.html with allowfullscreen = false

	4 FAIL Fullscreen enabled for self on URL: resources/feature-policy-fullscreen.htm l with allowfullscreen = true assert_false: expected false got true
	foolip 2016/12/02 10:52:09 To make it easier to see which assert this was tha To make it easier to see which assert this was that failed, you can add a short description to each, like assert_false(data.enabled, 'enabled'). In general I only bother when there are mulitple asserts of the same type though. lunalu1 2016/12/02 19:22:06 Done. Show quoted text On 2016/12/02 10:52:09, foolip wrote: > To make it easier to see which assert this was that failed, you can add a short > description to each, like assert_false(data.enabled, 'enabled'). In general I > only bother when there are mulitple asserts of the same type though. Done.
	5 FAIL Fullscreen enabled for self on URL: http://localhost:8000/feature-policy/re sources/feature-policy-fullscreen.html with allowfullscreen = true assert_false: expected false got true

	6 Harness: the test ran to completion.

	7

OLD	NEW