Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2499353002: Fix flakiness in v/t/fast/compositorworker/basic-plumbing-main-to-worker.html (Closed)

Created:
4 years, 1 month ago by majidvp
Modified:
4 years, 1 month ago
Reviewers:
flackr
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flakiness in v/t/fast/compositorworker/basic-plumbing-main-to-worker.html Most of the flakiness I have seen is related to the fact the waiting on one rAF does not guarantee that the change is activated on the compositor. This is fixed by waiting two rAF which ensures at least one activation has happened. I have also noticed a rare crash which I am continuing to investigate. This is why I am keeping the flakiness entry still. BUG=658311 Committed: https://crrev.com/62535f1781f16f8995522924fa1e1218d3cbad39 Cr-Commit-Position: refs/heads/master@{#432257}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/basic-plumbing-main-to-worker.html View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
majidvp
4 years, 1 month ago (2016-11-15 18:58:49 UTC) #4
flackr
lgtm
4 years, 1 month ago (2016-11-15 20:28:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2499353002/1
4 years, 1 month ago (2016-11-15 20:56:50 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 21:11:31 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 21:18:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62535f1781f16f8995522924fa1e1218d3cbad39
Cr-Commit-Position: refs/heads/master@{#432257}

Powered by Google App Engine
This is Rietveld 408576698