Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(905)

Unified Diff: content/test/test_render_frame_host.cc

Issue 2499313003: Set user_gesture bit at NavigationHandle creation time. (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/test_render_frame_host.cc
diff --git a/content/test/test_render_frame_host.cc b/content/test/test_render_frame_host.cc
index 4d7efdfb471f44bff4cf4b83ba83ae695d925f88..1a11e5a7071f3cf2ffbb9fa7b2c9395ff69a75dd 100644
--- a/content/test/test_render_frame_host.cc
+++ b/content/test/test_render_frame_host.cc
@@ -110,7 +110,7 @@ void TestRenderFrameHost::SimulateNavigationStart(const GURL& url) {
}
OnDidStartLoading(true);
- OnDidStartProvisionalLoad(url, base::TimeTicks::Now());
+ OnDidStartProvisionalLoad(url, base::TimeTicks::Now(), NavigationGestureUser);
SimulateWillStartRequest(ui::PAGE_TRANSITION_LINK);
}
@@ -199,7 +199,8 @@ void TestRenderFrameHost::SimulateNavigationError(const GURL& url,
void TestRenderFrameHost::SimulateNavigationErrorPageCommit() {
CHECK(navigation_handle());
GURL error_url = GURL(kUnreachableWebDataURL);
- OnDidStartProvisionalLoad(error_url, base::TimeTicks::Now());
+ OnDidStartProvisionalLoad(error_url, base::TimeTicks::Now(),
+ NavigationGestureUser);
FrameHostMsg_DidCommitProvisionalLoad_Params params;
params.nav_entry_id = 0;
params.did_create_new_entry = true;
@@ -307,7 +308,8 @@ void TestRenderFrameHost::SendNavigateWithParameters(
// DidStartProvisionalLoad may delete the pending entry that holds |url|,
// so we keep a copy of it to use below.
GURL url_copy(url);
- OnDidStartProvisionalLoad(url_copy, base::TimeTicks::Now());
+ OnDidStartProvisionalLoad(url_copy, base::TimeTicks::Now(),
+ NavigationGestureUser);
SimulateWillStartRequest(transition);
FrameHostMsg_DidCommitProvisionalLoad_Params params;
@@ -396,13 +398,14 @@ void TestRenderFrameHost::SendRendererInitiatedNavigationRequest(
InitializeRenderFrameIfNeeded();
if (IsBrowserSideNavigationEnabled()) {
- BeginNavigationParams begin_params(std::string(), net::LOAD_NORMAL,
- has_user_gesture, false,
+ BeginNavigationParams begin_params(std::string(), net::LOAD_NORMAL, false,
REQUEST_CONTEXT_TYPE_HYPERLINK);
CommonNavigationParams common_params;
common_params.url = url;
common_params.referrer = Referrer(GURL(), blink::WebReferrerPolicyDefault);
common_params.transition = ui::PAGE_TRANSITION_LINK;
+ common_params.gesture =
+ has_user_gesture ? NavigationGestureUser : NavigationGestureAuto;
OnBeginNavigation(common_params, begin_params);
}
}
@@ -485,7 +488,7 @@ void TestRenderFrameHost::SimulateWillStartRequest(
return;
navigation_handle()->CallWillStartRequestForTesting(
false /* is_post */, Referrer(GURL(), blink::WebReferrerPolicyDefault),
- true /* user_gesture */, transition, false /* is_external_protocol */);
+ transition, false /* is_external_protocol */);
}
} // namespace content
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698