Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6397)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 2499313003: Set user_gesture bit at NavigationHandle creation time. (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index 8025c71da8d2e87e350907864428a552ff12c2fd..8556fb22081e5b385925be502ca5585fa0bcaa37 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -1110,14 +1110,15 @@ void RenderFrameHostImpl::OnDocumentOnLoadCompleted(
void RenderFrameHostImpl::OnDidStartProvisionalLoad(
const GURL& url,
- const base::TimeTicks& navigation_start) {
+ const base::TimeTicks& navigation_start,
+ NavigationGesture gesture) {
// TODO(clamy): Check if other navigation methods (OpenURL,
// DidFailProvisionalLoad, ...) should also be ignored if the RFH is no longer
// active.
if (!is_active())
return;
- frame_tree_node_->navigator()->DidStartProvisionalLoad(this, url,
- navigation_start);
+ frame_tree_node_->navigator()->DidStartProvisionalLoad(
+ this, url, navigation_start, gesture);
}
void RenderFrameHostImpl::OnDidFailProvisionalLoadWithError(
@@ -2431,9 +2432,9 @@ void RenderFrameHostImpl::NavigateToInterstitialURL(const GURL& data_url) {
DCHECK(data_url.SchemeIs(url::kDataScheme));
CommonNavigationParams common_params(
data_url, Referrer(), ui::PAGE_TRANSITION_LINK,
- FrameMsg_Navigate_Type::NORMAL, false, false, base::TimeTicks::Now(),
- FrameMsg_UILoadMetricsReportType::NO_REPORT, GURL(), GURL(), LOFI_OFF,
- base::TimeTicks::Now(), "GET", nullptr);
+ FrameMsg_Navigate_Type::NORMAL, NavigationGestureAuto, false, false,
+ base::TimeTicks::Now(), FrameMsg_UILoadMetricsReportType::NO_REPORT,
+ GURL(), GURL(), LOFI_OFF, base::TimeTicks::Now(), "GET", nullptr);
if (IsBrowserSideNavigationEnabled()) {
CommitNavigation(nullptr, nullptr, common_params, RequestNavigationParams(),
false);
@@ -3289,7 +3290,8 @@ RenderFrameHostImpl::TakeNavigationHandleForCommit(
return NavigationHandleImpl::Create(
params.url, frame_tree_node_, is_renderer_initiated,
params.was_within_same_page, params.is_srcdoc, base::TimeTicks::Now(),
- pending_nav_entry_id, false); // started_from_context_menu
+ pending_nav_entry_id, params.gesture,
+ false); // started_from_context_menu
}
// Determine if the current NavigationHandle can be used.
@@ -3341,7 +3343,8 @@ RenderFrameHostImpl::TakeNavigationHandleForCommit(
return NavigationHandleImpl::Create(
params.url, frame_tree_node_, is_renderer_initiated,
params.was_within_same_page, params.is_srcdoc, base::TimeTicks::Now(),
- entry_id_for_data_nav, false); // started_from_context_menu
+ entry_id_for_data_nav, params.gesture,
+ false); // started_from_context_menu
}
} // namespace content
« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.h ('k') | content/browser/loader/navigation_resource_throttle.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698