Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Unified Diff: content/browser/frame_host/navigation_handle_impl.h

Issue 2499313003: Set user_gesture bit at NavigationHandle creation time. (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_handle_impl.h
diff --git a/content/browser/frame_host/navigation_handle_impl.h b/content/browser/frame_host/navigation_handle_impl.h
index c02844b80f469e4fffd04f4dabee9f9eb87d0584..668ba9b08fad4dbab5c84d944d862b25d27e1abb 100644
--- a/content/browser/frame_host/navigation_handle_impl.h
+++ b/content/browser/frame_host/navigation_handle_impl.h
@@ -85,6 +85,7 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
bool is_srcdoc,
const base::TimeTicks& navigation_start,
int pending_nav_entry_id,
+ NavigationGesture gesture,
bool started_from_context_menu);
~NavigationHandleImpl() override;
@@ -119,7 +120,6 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
NavigationThrottle::ThrottleCheckResult CallWillStartRequestForTesting(
bool is_post,
const Referrer& sanitized_referrer,
- bool has_user_gesture,
ui::PageTransition transition,
bool is_external_protocol) override;
NavigationThrottle::ThrottleCheckResult CallWillRedirectRequestForTesting(
@@ -208,7 +208,6 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
const std::string& method,
scoped_refptr<content::ResourceRequestBodyImpl> resource_request_body,
const Referrer& sanitized_referrer,
- bool has_user_gesture,
ui::PageTransition transition,
bool is_external_protocol,
RequestContextType request_context_type,
@@ -309,6 +308,7 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
bool is_srcdoc,
const base::TimeTicks& navigation_start,
int pending_nav_entry_id,
+ NavigationGesture gesture,
bool started_from_context_menu);
NavigationThrottle::ThrottleCheckResult CheckWillStartRequest();
@@ -342,7 +342,7 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
GURL url_;
scoped_refptr<SiteInstance> starting_site_instance_;
Referrer sanitized_referrer_;
- bool has_user_gesture_;
+ NavigationGesture gesture_;
ui::PageTransition transition_;
bool is_external_protocol_;
net::Error net_error_code_;
« no previous file with comments | « content/browser/frame_host/navigation_entry_impl.cc ('k') | content/browser/frame_host/navigation_handle_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698