content/common/frame_messages.h - Issue 2499313003: Set user_gesture bit at NavigationHandle creation time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/frame_messages.h

Issue 2499313003: Set user_gesture bit at NavigationHandle creation time. (Closed)

Patch Set: address comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigation_handle_impl.cc ('K') | « content/browser/web_contents/web_contents_impl_unittest.cc ('k') | content/common/navigation_params.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/frame_messages.h

diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h

index de03e5577869d83b837a828f4cc9c49caff7014e..5a7ff304e87185758292f805ec4d0c6a42992527 100644

--- a/content/common/frame_messages.h

+++ b/content/common/frame_messages.h

@@ -338,6 +338,7 @@ IPC_STRUCT_TRAITS_BEGIN(content::CommonNavigationParams)

IPC_STRUCT_TRAITS_MEMBER(referrer)

IPC_STRUCT_TRAITS_MEMBER(transition)

IPC_STRUCT_TRAITS_MEMBER(navigation_type)

+ IPC_STRUCT_TRAITS_MEMBER(gesture)

IPC_STRUCT_TRAITS_MEMBER(allow_download)

IPC_STRUCT_TRAITS_MEMBER(should_replace_current_entry)

IPC_STRUCT_TRAITS_MEMBER(ui_timestamp)

@@ -353,7 +354,6 @@ IPC_STRUCT_TRAITS_END()

IPC_STRUCT_TRAITS_BEGIN(content::BeginNavigationParams)

IPC_STRUCT_TRAITS_MEMBER(headers)

IPC_STRUCT_TRAITS_MEMBER(load_flags)

- IPC_STRUCT_TRAITS_MEMBER(has_user_gesture)

IPC_STRUCT_TRAITS_MEMBER(skip_service_worker)

IPC_STRUCT_TRAITS_MEMBER(request_context_type)

IPC_STRUCT_TRAITS_MEMBER(searchable_form_url)

@@ -392,7 +392,6 @@ IPC_STRUCT_TRAITS_BEGIN(content::RequestNavigationParams)

IPC_STRUCT_TRAITS_MEMBER(should_create_service_worker)

IPC_STRUCT_TRAITS_MEMBER(navigation_timing)

IPC_STRUCT_TRAITS_MEMBER(service_worker_provider_id)

- IPC_STRUCT_TRAITS_MEMBER(has_user_gesture)

#if defined(OS_ANDROID)

IPC_STRUCT_TRAITS_MEMBER(data_url_as_string)

#endif

@@ -969,9 +968,10 @@ IPC_MESSAGE_ROUTED2(FrameHostMsg_RenderProcessGone,

IPC_MESSAGE_ROUTED0(FrameHostMsg_FrameFocused)

// Sent when the renderer starts a provisional load for a frame.

-IPC_MESSAGE_ROUTED2(FrameHostMsg_DidStartProvisionalLoad,

+IPC_MESSAGE_ROUTED3(FrameHostMsg_DidStartProvisionalLoad,

GURL /* url */,

- base::TimeTicks /* navigation_start */)

+ base::TimeTicks /* navigation_start */,

+ content::NavigationGesture /* gesture */)

// Sent when the renderer fails a provisional load with an error.

IPC_MESSAGE_ROUTED1(FrameHostMsg_DidFailProvisionalLoadWithError,