Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Unified Diff: content/browser/frame_host/navigation_request.cc

Issue 2499313003: Set user_gesture bit at NavigationHandle creation time. (Closed)
Patch Set: comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_request.cc
diff --git a/content/browser/frame_host/navigation_request.cc b/content/browser/frame_host/navigation_request.cc
index 4c24485495582a9779114f52df872e9a33ff8b8c..8bf29b386fc2ff30db8d9dcc623eb22009e855f8 100644
--- a/content/browser/frame_host/navigation_request.cc
+++ b/content/browser/frame_host/navigation_request.cc
@@ -279,8 +279,7 @@ void NavigationRequest::BeginNavigation() {
common_params_.method, common_params_.post_data,
Referrer::SanitizeForRequest(common_params_.url,
common_params_.referrer),
- begin_params_.has_user_gesture, common_params_.transition, false,
- begin_params_.request_context_type,
+ common_params_.transition, false, begin_params_.request_context_type,
base::Bind(&NavigationRequest::OnStartChecksComplete,
base::Unretained(this)));
return;
@@ -302,14 +301,15 @@ void NavigationRequest::BeginNavigation() {
CommitNavigation();
}
-void NavigationRequest::CreateNavigationHandle(int pending_nav_entry_id) {
+void NavigationRequest::CreateNavigationHandle(int pending_nav_entry_id,
+ bool has_user_gesture) {
// TODO(nasko): Update the NavigationHandle creation to ensure that the
// proper values are specified for is_same_page and is_srcdoc.
navigation_handle_ = NavigationHandleImpl::Create(
common_params_.url, frame_tree_node_, !browser_initiated_,
false, // is_same_page
false, // is_srcdoc
- common_params_.navigation_start, pending_nav_entry_id,
+ common_params_.navigation_start, pending_nav_entry_id, has_user_gesture,
false); // started_in_context_menu
if (!begin_params_.searchable_form_url.is_empty()) {

Powered by Google App Engine
This is Rietveld 408576698