Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2322)

Unified Diff: content/browser/frame_host/navigation_handle_impl.h

Issue 2499313003: Set user_gesture bit at NavigationHandle creation time. (Closed)
Patch Set: comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_handle_impl.h
diff --git a/content/browser/frame_host/navigation_handle_impl.h b/content/browser/frame_host/navigation_handle_impl.h
index 3eeed430174884bb1da488b9bfb8d4be41348b96..f77e04323337e72b2e448a455df50a6593006277 100644
--- a/content/browser/frame_host/navigation_handle_impl.h
+++ b/content/browser/frame_host/navigation_handle_impl.h
@@ -81,6 +81,7 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
bool is_srcdoc,
const base::TimeTicks& navigation_start,
int pending_nav_entry_id,
+ bool has_user_gesture,
bool started_from_context_menu);
~NavigationHandleImpl() override;
@@ -115,7 +116,6 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
NavigationThrottle::ThrottleCheckResult CallWillStartRequestForTesting(
bool is_post,
const Referrer& sanitized_referrer,
- bool has_user_gesture,
ui::PageTransition transition,
bool is_external_protocol) override;
NavigationThrottle::ThrottleCheckResult CallWillRedirectRequestForTesting(
@@ -203,7 +203,6 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
const std::string& method,
scoped_refptr<content::ResourceRequestBodyImpl> resource_request_body,
const Referrer& sanitized_referrer,
- bool has_user_gesture,
ui::PageTransition transition,
bool is_external_protocol,
RequestContextType request_context_type,
@@ -313,6 +312,7 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
bool is_srcdoc,
const base::TimeTicks& navigation_start,
int pending_nav_entry_id,
+ bool has_user_gesture,
bool started_from_context_menu);
NavigationThrottle::ThrottleCheckResult CheckWillStartRequest();
@@ -346,7 +346,7 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
GURL url_;
scoped_refptr<SiteInstance> starting_site_instance_;
Referrer sanitized_referrer_;
- bool has_user_gesture_;
+ const bool has_user_gesture_;
ui::PageTransition transition_;
bool is_external_protocol_;
net::Error net_error_code_;

Powered by Google App Engine
This is Rietveld 408576698