Set user_gesture bit at NavigationHandle creation time.

content/browser/frame_host/render_frame_host_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_frame_host_impl.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 1050 matching lines @@
                                base::TimeDelta::FromMilliseconds(10),
                                base::TimeDelta::FromMinutes(10), 100);
   }
   // This message is only sent for top-level frames. TODO(avi): when frame tree
   // mirroring works correctly, add a check here to enforce it.
   delegate_->DocumentOnLoadCompleted(this);
 }
 
 void RenderFrameHostImpl::OnDidStartProvisionalLoad(
     const GURL& url,
-    const base::TimeTicks& navigation_start) {
+    const base::TimeTicks& navigation_start,
+    bool has_user_gesture) {
   // TODO(clamy): Check if other navigation methods (OpenURL,
   // DidFailProvisionalLoad, ...) should also be ignored if the RFH is no longer
   // active.
   if (!is_active())
     return;
-  frame_tree_node_->navigator()->DidStartProvisionalLoad(this, url,
-                                                         navigation_start);
+  frame_tree_node_->navigator()->DidStartProvisionalLoad(
+      this, url, navigation_start, has_user_gesture);
 }
 
 void RenderFrameHostImpl::OnDidFailProvisionalLoadWithError(
     const FrameHostMsg_DidFailProvisionalLoadWithError_Params& params) {
   // TODO(clamy): Kill the renderer with RFH_FAIL_PROVISIONAL_LOAD_NO_HANDLE and
   // return early if navigation_handle_ is null, once we prevent that case from
   // happening in practice.
 
   // Update the error code in the NavigationHandle of the navigation.
   if (navigation_handle_) {
@@ skipping 2127 matching lines @@
         NavigationEntryImpl::FromNavigationEntry(
             frame_tree_node()->navigator()->GetController()->GetPendingEntry());
     if (pending_entry && pending_entry->GetUniqueID() == params.nav_entry_id) {
       pending_nav_entry_id = params.nav_entry_id;
       is_renderer_initiated = pending_entry->is_renderer_initiated();
     }
 
     return NavigationHandleImpl::Create(
         params.url, frame_tree_node_, is_renderer_initiated,
         params.was_within_same_page, params.is_srcdoc, base::TimeTicks::Now(),
-        pending_nav_entry_id, false);  // started_from_context_menu
+        pending_nav_entry_id, params.gesture == NavigationGestureUser,

[clamy, 2016/11/17 14:30:04]

While we're at it, why not replace the has_user_gesture boolean in
NavigationHandle by an actual NavigationGesture? This would also require to
modify the DidStartProvisionalLoad & BeginNavigation IPCs.

[Bryan McQuade, 2016/11/19 20:21:38]

Sure, makes sense, thanks! I went ahead and did the same for
BeginNavigationParams and RequestNavigationParams, as well.

+        false);  // started_from_context_menu
   }
 
   // Determine if the current NavigationHandle can be used.
   if (navigation_handle_ && navigation_handle_->GetURL() == params.url) {
     return std::move(navigation_handle_);
   }
 
   // If the URL does not match what the NavigationHandle expects, treat the
   // commit as a new navigation. This can happen when loading a Data
   // navigation with LoadDataWithBaseURL.
@@ skipping 31 matching lines @@
     // Reset any existing NavigationHandle.
     navigation_handle_.reset();
   }
 
   // There is no pending NavigationEntry in these cases, so pass 0 as the
   // pending_nav_entry_id. If the previous handle was a prematurely aborted
   // navigation loaded via LoadDataWithBaseURL, propagate the entry id.
   return NavigationHandleImpl::Create(
       params.url, frame_tree_node_, is_renderer_initiated,
       params.was_within_same_page, params.is_srcdoc, base::TimeTicks::Now(),
-      entry_id_for_data_nav, false);  // started_from_context_menu
+      entry_id_for_data_nav, params.gesture == NavigationGestureUser,
+      false);  // started_from_context_menu
 }
 
 }  // namespace content