Views:: Use TestClipboard in ScopedViewsTestHelper.

Views:: Use TestClipboard in ScopedViewsTestHelper.

Currently the behavior of any views_unittest which depends on clipboard is
flaky. This is because the Clipboard is a global/shared resource. Hence when
multiple tests are run in parallel, one test can modify the clipboard state,
causing another test to flake. This CL sets up a TestClipboard instance in the
ScopedViewsTestHelper. This should fix various flaky views_unittests, for
example:
- ViewTest.TextfieldCutCopyPaste
- TextfieldTest.ReadOnlyTest
- TextfieldTest.CutCopyPaste
- TextfieldTest.PasswordTest
etc.

The following tests (disabled due to flaky selection clipboard behavior) are re-
enabled:
- LabelSelectionTest.SelectionClipboard
- TextfieldTest.SelectionClipboard
- TextfieldTest.SelectionClipboard_Password

BUG=623442, 396477
Committed: https://crrev.com/80f0522d703aaf59ccbe0cb53f1eb8574187a265
Cr-Commit-Position: refs/heads/master@{#432659}

[karandeepb, 2016-11-16 01:31:59]

The CQ bit was checked by karandeepb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 01:32:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 02:25:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 02:25:12]

Dry run: This issue passed the CQ dry run.

[karandeepb, 2016-11-16 04:08:52]

Description was changed from

==========
Views:: Use TestClipboard in ScopedViewsTestHelper.
==========

to

==========
Views:: Use TestClipboard in ScopedViewsTestHelper.

Currently the behavior of any views_unittest which depends on clipboard is
flaky. This is because the Clipboard is a global/shared resource. Hence when
multiple tests are run in parallel, one test can modify the clipboard state,
causing another test to flake. This CL sets up a TestClipboard instance in the
ScopedViewsTestHelper. This fixes the flaky clipboard behavior for all
views_unittests and also any tests which have a ScopedViewsTestHelper instance.

The following tests (disabled due to flaky selection clipboard behavior) are re-
enabled:
- LabelSelectionTest.SelectionClipboard
- TextfieldTest.SelectionClipboard
- TextfieldTest.SelectionClipboard_Password

BUG=623442, 396477
==========

[karandeepb, 2016-11-16 04:16:14]

karandeepb@chromium.org changed reviewers:
+ dcheng@chromium.org, sky@chromium.org

[karandeepb, 2016-11-16 04:16:15]

PTAL.

dcheng@: TestClipboard doesn't seem to be used much in the codebase. Can you
verify that the usage here is appropriate?

https://codereview.chromium.org/2499303003/diff/20001/ui/views/controls/textf...
File ui/views/controls/textfield/textfield_unittest.cc (left):

https://codereview.chromium.org/2499303003/diff/20001/ui/views/controls/textf...
ui/views/controls/textfield/textfield_unittest.cc:2694:
SetClipboardText(ui::CLIPBOARD_TYPE_COPY_PASTE, std::string());
I think this was a mistake/typo.

https://codereview.chromium.org/2499303003/diff/20001/ui/views/test/scoped_vi...
File ui/views/test/scoped_views_test_helper.cc (right):

https://codereview.chromium.org/2499303003/diff/20001/ui/views/test/scoped_vi...
ui/views/test/scoped_views_test_helper.cc:63:
ui::TestClipboard::CreateForCurrentThread();
sky@: Should this go in ViewsTestBase or is this fine?

[karandeepb, 2016-11-16 04:23:32]

Description was changed from

==========
Views:: Use TestClipboard in ScopedViewsTestHelper.

Currently the behavior of any views_unittest which depends on clipboard is
flaky. This is because the Clipboard is a global/shared resource. Hence when
multiple tests are run in parallel, one test can modify the clipboard state,
causing another test to flake. This CL sets up a TestClipboard instance in the
ScopedViewsTestHelper. This fixes the flaky clipboard behavior for all
views_unittests and also any tests which have a ScopedViewsTestHelper instance.

The following tests (disabled due to flaky selection clipboard behavior) are re-
enabled:
- LabelSelectionTest.SelectionClipboard
- TextfieldTest.SelectionClipboard
- TextfieldTest.SelectionClipboard_Password

BUG=623442, 396477
==========

to

==========
Views:: Use TestClipboard in ScopedViewsTestHelper.

Currently the behavior of any views_unittest which depends on clipboard is
flaky. This is because the Clipboard is a global/shared resource. Hence when
multiple tests are run in parallel, one test can modify the clipboard state,
causing another test to flake. This CL sets up a TestClipboard instance in the
ScopedViewsTestHelper. This should fix various flaky views_unittests, for
example:
- ViewTest.TextfieldCutCopyPaste
- TextfieldTest.ReadOnlyTest
- TextfieldTest.CutCopyPaste
- TextfieldTest.PasswordTest
etc.

The following tests (disabled due to flaky selection clipboard behavior) are re-
enabled:
- LabelSelectionTest.SelectionClipboard
- TextfieldTest.SelectionClipboard
- TextfieldTest.SelectionClipboard_Password

BUG=623442, 396477
==========

[karandeepb, 2016-11-16 04:57:56]

Also, dcheng@: Is https://bugs.chromium.org/p/chromium/issues/detail?id=629765
relevant here as well?

[sky, 2016-11-16 16:43:29]

LGTM - where you put initialization is fine.

[dcheng, 2016-11-16 18:44:41]

On 2016/11/16 04:16:15, karandeepb wrote:
> PTAL.
> 
> dcheng@: TestClipboard doesn't seem to be used much in the codebase. Can you
> verify that the usage here is appropriate?

LGTM. TestClipboard isn't used much only because we added it much later: tests
using the clipboard mostly got away with this in the past, but after we switched
to the new test runner, these sorts of issues were triggered much more often.

> 
>
https://codereview.chromium.org/2499303003/diff/20001/ui/views/controls/textf...
> File ui/views/controls/textfield/textfield_unittest.cc (left):
> 
>
https://codereview.chromium.org/2499303003/diff/20001/ui/views/controls/textf...
> ui/views/controls/textfield/textfield_unittest.cc:2694:
> SetClipboardText(ui::CLIPBOARD_TYPE_COPY_PASTE, std::string());
> I think this was a mistake/typo.
> 
>
https://codereview.chromium.org/2499303003/diff/20001/ui/views/test/scoped_vi...
> File ui/views/test/scoped_views_test_helper.cc (right):
> 
>
https://codereview.chromium.org/2499303003/diff/20001/ui/views/test/scoped_vi...
> ui/views/test/scoped_views_test_helper.cc:63:
> ui::TestClipboard::CreateForCurrentThread();
> sky@: Should this go in ViewsTestBase or is this fine?

[karandeepb, 2016-11-16 22:45:10]

The CQ bit was checked by karandeepb@chromium.org

[commit-bot: I haz the power, 2016-11-16 22:46:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 23:12:55]

Description was changed from

==========
Views:: Use TestClipboard in ScopedViewsTestHelper.

Currently the behavior of any views_unittest which depends on clipboard is
flaky. This is because the Clipboard is a global/shared resource. Hence when
multiple tests are run in parallel, one test can modify the clipboard state,
causing another test to flake. This CL sets up a TestClipboard instance in the
ScopedViewsTestHelper. This should fix various flaky views_unittests, for
example:
- ViewTest.TextfieldCutCopyPaste
- TextfieldTest.ReadOnlyTest
- TextfieldTest.CutCopyPaste
- TextfieldTest.PasswordTest
etc.

The following tests (disabled due to flaky selection clipboard behavior) are re-
enabled:
- LabelSelectionTest.SelectionClipboard
- TextfieldTest.SelectionClipboard
- TextfieldTest.SelectionClipboard_Password

BUG=623442, 396477
==========

to

==========
Views:: Use TestClipboard in ScopedViewsTestHelper.

Currently the behavior of any views_unittest which depends on clipboard is
flaky. This is because the Clipboard is a global/shared resource. Hence when
multiple tests are run in parallel, one test can modify the clipboard state,
causing another test to flake. This CL sets up a TestClipboard instance in the
ScopedViewsTestHelper. This should fix various flaky views_unittests, for
example:
- ViewTest.TextfieldCutCopyPaste
- TextfieldTest.ReadOnlyTest
- TextfieldTest.CutCopyPaste
- TextfieldTest.PasswordTest
etc.

The following tests (disabled due to flaky selection clipboard behavior) are re-
enabled:
- LabelSelectionTest.SelectionClipboard
- TextfieldTest.SelectionClipboard
- TextfieldTest.SelectionClipboard_Password

BUG=623442, 396477
==========

[commit-bot: I haz the power, 2016-11-16 23:12:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-16 23:15:19]

Description was changed from

==========
Views:: Use TestClipboard in ScopedViewsTestHelper.

Currently the behavior of any views_unittest which depends on clipboard is
flaky. This is because the Clipboard is a global/shared resource. Hence when
multiple tests are run in parallel, one test can modify the clipboard state,
causing another test to flake. This CL sets up a TestClipboard instance in the
ScopedViewsTestHelper. This should fix various flaky views_unittests, for
example:
- ViewTest.TextfieldCutCopyPaste
- TextfieldTest.ReadOnlyTest
- TextfieldTest.CutCopyPaste
- TextfieldTest.PasswordTest
etc.

The following tests (disabled due to flaky selection clipboard behavior) are re-
enabled:
- LabelSelectionTest.SelectionClipboard
- TextfieldTest.SelectionClipboard
- TextfieldTest.SelectionClipboard_Password

BUG=623442, 396477
==========

to

==========
Views:: Use TestClipboard in ScopedViewsTestHelper.

Currently the behavior of any views_unittest which depends on clipboard is
flaky. This is because the Clipboard is a global/shared resource. Hence when
multiple tests are run in parallel, one test can modify the clipboard state,
causing another test to flake. This CL sets up a TestClipboard instance in the
ScopedViewsTestHelper. This should fix various flaky views_unittests, for
example:
- ViewTest.TextfieldCutCopyPaste
- TextfieldTest.ReadOnlyTest
- TextfieldTest.CutCopyPaste
- TextfieldTest.PasswordTest
etc.

The following tests (disabled due to flaky selection clipboard behavior) are re-
enabled:
- LabelSelectionTest.SelectionClipboard
- TextfieldTest.SelectionClipboard
- TextfieldTest.SelectionClipboard_Password

BUG=623442, 396477

Committed: https://crrev.com/80f0522d703aaf59ccbe0cb53f1eb8574187a265
Cr-Commit-Position: refs/heads/master@{#432659}
==========

[commit-bot: I haz the power, 2016-11-16 23:15:20]

Patchset 2 (id:??) landed as
https://crrev.com/80f0522d703aaf59ccbe0cb53f1eb8574187a265
Cr-Commit-Position: refs/heads/master@{#432659}