[inspector] introduced Script::TYPE_INSPECTOR

[inspector] introduced Script::TYPE_INSPECTOR

Inspector uses this type for all internal scripts, e.g. injected-script-source.js. Scripts with new type are not reported by remote debugging protocol, frames from them are ignored.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
BUG=none
R=yangguo@chromium.org,dgozman@chromium.org

Committed: https://crrev.com/6808ec1f83435c365db196313370c35e5f51147d
Cr-Commit-Position: refs/heads/master@{#41056}

[kozy, 2016-11-15 19:54:54]

Description was changed from

==========
[inspector] introduce Script::TYPE_INSPECTOR

Inspector uses this type for all internal scripts, e.g.
injected-script-source.js.

BUG=none
R=yangguo@chromium.org,dgozman@chromium.org
==========

to

==========
[inspector] introduce Script::TYPE_INSPECTOR

Inspector uses this type for all internal scripts, e.g.
injected-script-source.js.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
BUG=none
R=yangguo@chromium.org,dgozman@chromium.org
==========

[kozy, 2016-11-15 19:58:03]

Description was changed from

==========
[inspector] introduce Script::TYPE_INSPECTOR

Inspector uses this type for all internal scripts, e.g.
injected-script-source.js.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
BUG=none
R=yangguo@chromium.org,dgozman@chromium.org
==========

to

==========
[inspector] introduced Script::TYPE_INSPECTOR

Inspector uses this type for all internal scripts, e.g.
injected-script-source.js. Scripts with new type are not reported by remote
debugging protocol, frames from them are ignored.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
BUG=none
R=yangguo@chromium.org,dgozman@chromium.org
==========

[kozy, 2016-11-15 20:02:14]

Yang, please take a look.

I introduced new Script::Type to address your comments in
https://codereview.chromium.org/2499093003/.

I'll remove is_embedder_debug_script flag from public API in three steps:
 - introduce new ScriptOrigin constructor without this flag,
 - migrate chromium to new constructor,
 - get rid of this flag in V8 code base.

Dmitry, please take a look on inspector changes.
The main one - I changed type of script that we generate in callFunctionOn
method by function declaration from internal to regular one. We report
compilation error location in ExceptionDetails, I think it will be useful to
report script too.

[kozy, 2016-11-15 20:02:46]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 20:02:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 21:33:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 21:34:00]

Dry run: Try jobs failed on following builders:
  linux_precise_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_precise_blink_rel/...)

[dgozman, 2016-11-15 23:19:57]

https://codereview.chromium.org/2499273003/diff/1/src/inspector/v8-inspector-...
File src/inspector/v8-inspector-impl.cc (right):

https://codereview.chromium.org/2499273003/diff/1/src/inspector/v8-inspector-...
src/inspector/v8-inspector-impl.cc:122: return
unboundScript->BindToCurrentContext()->Run(context);
I think we have to enter context before bindings to current one.

https://codereview.chromium.org/2499273003/diff/1/src/inspector/v8-runtime-ag...
File src/inspector/v8-runtime-agent-impl.cc (right):

https://codereview.chromium.org/2499273003/diff/1/src/inspector/v8-runtime-ag...
src/inspector/v8-runtime-agent-impl.cc:388:
m_inspector->runCompiledScript(scope.context(), functionScript);
Let's add a test for compile error in callFunctionOn.

[kozy, 2016-11-16 00:10:50]

All done.

https://codereview.chromium.org/2499273003/diff/1/src/inspector/v8-inspector-...
File src/inspector/v8-inspector-impl.cc (right):

https://codereview.chromium.org/2499273003/diff/1/src/inspector/v8-inspector-...
src/inspector/v8-inspector-impl.cc:122: return
unboundScript->BindToCurrentContext()->Run(context);
On 2016/11/15 23:19:57, dgozman wrote:
> I think we have to enter context before bindings to current one.

I assume that we pass entered context into this function and all call sites
actually enter this context before call.
Added explicit Context::Scope.

https://codereview.chromium.org/2499273003/diff/1/src/inspector/v8-runtime-ag...
File src/inspector/v8-runtime-agent-impl.cc (right):

https://codereview.chromium.org/2499273003/diff/1/src/inspector/v8-runtime-ag...
src/inspector/v8-runtime-agent-impl.cc:388:
m_inspector->runCompiledScript(scope.context(), functionScript);
On 2016/11/15 23:19:57, dgozman wrote:
> Let's add a test for compile error in callFunctionOn.

Done.

[Yang, 2016-11-16 07:36:03]

On 2016/11/16 00:10:50, kozyatinskiy wrote:
> All done.
> 
>
https://codereview.chromium.org/2499273003/diff/1/src/inspector/v8-inspector-...
> File src/inspector/v8-inspector-impl.cc (right):
> 
>
https://codereview.chromium.org/2499273003/diff/1/src/inspector/v8-inspector-...
> src/inspector/v8-inspector-impl.cc:122: return
> unboundScript->BindToCurrentContext()->Run(context);
> On 2016/11/15 23:19:57, dgozman wrote:
> > I think we have to enter context before bindings to current one.
> 
> I assume that we pass entered context into this function and all call sites
> actually enter this context before call.
> Added explicit Context::Scope.
> 
>
https://codereview.chromium.org/2499273003/diff/1/src/inspector/v8-runtime-ag...
> File src/inspector/v8-runtime-agent-impl.cc (right):
> 
>
https://codereview.chromium.org/2499273003/diff/1/src/inspector/v8-runtime-ag...
> src/inspector/v8-runtime-agent-impl.cc:388:
> m_inspector->runCompiledScript(scope.context(), functionScript);
> On 2016/11/15 23:19:57, dgozman wrote:
> > Let's add a test for compile error in callFunctionOn.
> 
> Done.

lgtm!

[kozy, 2016-11-16 17:05:35]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 17:05:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 17:06:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 17:06:56]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)

[dgozman, 2016-11-16 19:48:28]

lgtm

[kozy, 2016-11-17 03:33:36]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-11-17 03:33:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2499273003/#ps60001
(title: "rebased")

[commit-bot: I haz the power, 2016-11-17 03:33:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 04:39:37]

Description was changed from

==========
[inspector] introduced Script::TYPE_INSPECTOR

Inspector uses this type for all internal scripts, e.g.
injected-script-source.js. Scripts with new type are not reported by remote
debugging protocol, frames from them are ignored.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
BUG=none
R=yangguo@chromium.org,dgozman@chromium.org
==========

to

==========
[inspector] introduced Script::TYPE_INSPECTOR

Inspector uses this type for all internal scripts, e.g.
injected-script-source.js. Scripts with new type are not reported by remote
debugging protocol, frames from them are ignored.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
BUG=none
R=yangguo@chromium.org,dgozman@chromium.org
==========

[commit-bot: I haz the power, 2016-11-17 04:39:38]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-17 22:37:20]

Description was changed from

==========
[inspector] introduced Script::TYPE_INSPECTOR

Inspector uses this type for all internal scripts, e.g.
injected-script-source.js. Scripts with new type are not reported by remote
debugging protocol, frames from them are ignored.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
BUG=none
R=yangguo@chromium.org,dgozman@chromium.org
==========

to

==========
[inspector] introduced Script::TYPE_INSPECTOR

Inspector uses this type for all internal scripts, e.g.
injected-script-source.js. Scripts with new type are not reported by remote
debugging protocol, frames from them are ignored.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
BUG=none
R=yangguo@chromium.org,dgozman@chromium.org

Committed: https://crrev.com/6808ec1f83435c365db196313370c35e5f51147d
Cr-Commit-Position: refs/heads/master@{#41056}
==========

[commit-bot: I haz the power, 2016-11-17 22:37:21]

Patchset 4 (id:??) landed as
https://crrev.com/6808ec1f83435c365db196313370c35e5f51147d
Cr-Commit-Position: refs/heads/master@{#41056}