Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: third_party/WebKit/Source/core/fetch/ImageResource.cpp

Issue 2499263002: Add UMA to estimate deroppable memory usage of encoded data size in Resources (Closed)
Patch Set: Address on yhirano's review Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/ImageResource.cpp
diff --git a/third_party/WebKit/Source/core/fetch/ImageResource.cpp b/third_party/WebKit/Source/core/fetch/ImageResource.cpp
index dba77fe8f5ee36c3f854c9ad3502e47b888015f0..8f9f0c1d7a7b1cf0e8ea8a8e6e2030e2e22d107f 100644
--- a/third_party/WebKit/Source/core/fetch/ImageResource.cpp
+++ b/third_party/WebKit/Source/core/fetch/ImageResource.cpp
@@ -23,6 +23,7 @@
#include "core/fetch/ImageResource.h"
+#include "base/metrics/histogram_macros.h"
#include "core/fetch/ImageResourceObserver.h"
#include "core/fetch/MemoryCache.h"
#include "core/fetch/ResourceClient.h"
@@ -114,7 +115,8 @@ ImageResource::ImageResource(const ResourceRequest& resourceRequest,
m_hasDevicePixelRatioHeaderValue(false),
m_isSchedulingReload(false),
m_isPlaceholder(isPlaceholder),
- m_flushTimer(this, &ImageResource::flushImageIfNeeded) {
+ m_flushTimer(this, &ImageResource::flushImageIfNeeded),
+ m_isRefetchableDataFromDiskCache(true) {
RESOURCE_LOADING_DVLOG(1) << "new ImageResource(ResourceRequest) " << this;
}
@@ -126,7 +128,8 @@ ImageResource::ImageResource(blink::Image* image,
m_hasDevicePixelRatioHeaderValue(false),
m_isSchedulingReload(false),
m_isPlaceholder(false),
- m_flushTimer(this, &ImageResource::flushImageIfNeeded) {
+ m_flushTimer(this, &ImageResource::flushImageIfNeeded),
+ m_isRefetchableDataFromDiskCache(true) {
RESOURCE_LOADING_DVLOG(1) << "new ImageResource(Image) " << this;
setStatus(Cached);
}
@@ -260,6 +263,10 @@ void ImageResource::destroyDecodedDataIfPossible() {
return;
CHECK(!errorOccurred());
m_image->destroyDecodedData();
+ if (!isPreloaded() && m_isRefetchableDataFromDiskCache) {
+ UMA_HISTOGRAM_MEMORY_KB("Memory.Renderer.EstimatedDroppableEncodedSize",
+ encodedSize() / 1024);
+ }
}
void ImageResource::doResetAnimation() {

Powered by Google App Engine
This is Rietveld 408576698