Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: third_party/WebKit/Source/core/fetch/ImageResource.cpp

Issue 2499263002: Add UMA to estimate deroppable memory usage of encoded data size in Resources (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de) 2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
3 Copyright (C) 2001 Dirk Mueller (mueller@kde.org) 3 Copyright (C) 2001 Dirk Mueller (mueller@kde.org)
4 Copyright (C) 2002 Waldo Bastian (bastian@kde.org) 4 Copyright (C) 2002 Waldo Bastian (bastian@kde.org)
5 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 5 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
6 Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 6 Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
7 7
8 This library is free software; you can redistribute it and/or 8 This library is free software; you can redistribute it and/or
9 modify it under the terms of the GNU Library General Public 9 modify it under the terms of the GNU Library General Public
10 License as published by the Free Software Foundation; either 10 License as published by the Free Software Foundation; either
11 version 2 of the License, or (at your option) any later version. 11 version 2 of the License, or (at your option) any later version.
12 12
13 This library is distributed in the hope that it will be useful, 13 This library is distributed in the hope that it will be useful,
14 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 but WITHOUT ANY WARRANTY; without even the implied warranty of
15 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 15 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
16 Library General Public License for more details. 16 Library General Public License for more details.
17 17
18 You should have received a copy of the GNU Library General Public License 18 You should have received a copy of the GNU Library General Public License
19 along with this library; see the file COPYING.LIB. If not, write to 19 along with this library; see the file COPYING.LIB. If not, write to
20 the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 20 the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
21 Boston, MA 02110-1301, USA. 21 Boston, MA 02110-1301, USA.
22 */ 22 */
23 23
24 #include "core/fetch/ImageResource.h" 24 #include "core/fetch/ImageResource.h"
25 25
26 #include "base/metrics/histogram_macros.h"
26 #include "core/fetch/ImageResourceObserver.h" 27 #include "core/fetch/ImageResourceObserver.h"
27 #include "core/fetch/MemoryCache.h" 28 #include "core/fetch/MemoryCache.h"
28 #include "core/fetch/ResourceClient.h" 29 #include "core/fetch/ResourceClient.h"
29 #include "core/fetch/ResourceFetcher.h" 30 #include "core/fetch/ResourceFetcher.h"
30 #include "core/fetch/ResourceLoader.h" 31 #include "core/fetch/ResourceLoader.h"
31 #include "core/fetch/ResourceLoadingLog.h" 32 #include "core/fetch/ResourceLoadingLog.h"
32 #include "core/svg/graphics/SVGImage.h" 33 #include "core/svg/graphics/SVGImage.h"
33 #include "platform/RuntimeEnabledFeatures.h" 34 #include "platform/RuntimeEnabledFeatures.h"
34 #include "platform/SharedBuffer.h" 35 #include "platform/SharedBuffer.h"
35 #include "platform/geometry/IntSize.h" 36 #include "platform/geometry/IntSize.h"
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 void ImageResource::destroyDecodedDataForFailedRevalidation() { 246 void ImageResource::destroyDecodedDataForFailedRevalidation() {
246 clearImage(); 247 clearImage();
247 setDecodedSize(0); 248 setDecodedSize(0);
248 } 249 }
249 250
250 void ImageResource::destroyDecodedDataIfPossible() { 251 void ImageResource::destroyDecodedDataIfPossible() {
251 if (!m_image) 252 if (!m_image)
252 return; 253 return;
253 CHECK(!errorOccurred()); 254 CHECK(!errorOccurred());
254 m_image->destroyDecodedData(); 255 m_image->destroyDecodedData();
256 if (!isPreloaded() && isReloadable()) {
257 UMA_HISTOGRAM_MEMORY_KB("Memory.Renderer.EstimantedDroppableEncodedSize",
258 encodedSize() / 1024);
259 }
255 } 260 }
256 261
257 void ImageResource::doResetAnimation() { 262 void ImageResource::doResetAnimation() {
258 if (m_image) 263 if (m_image)
259 m_image->resetAnimation(); 264 m_image->resetAnimation();
260 } 265 }
261 266
262 void ImageResource::allClientsAndObserversRemoved() { 267 void ImageResource::allClientsAndObserversRemoved() {
263 if (m_image) { 268 if (m_image) {
264 CHECK(!errorOccurred()); 269 CHECK(!errorOccurred());
(...skipping 414 matching lines...) Expand 10 before | Expand all | Expand 10 after
679 WebServiceWorkerResponseTypeOpaque; 684 WebServiceWorkerResponseTypeOpaque;
680 } 685 }
681 if (!getImage()->currentFrameHasSingleSecurityOrigin()) 686 if (!getImage()->currentFrameHasSingleSecurityOrigin())
682 return false; 687 return false;
683 if (passesAccessControlCheck(securityOrigin)) 688 if (passesAccessControlCheck(securityOrigin))
684 return true; 689 return true;
685 return !securityOrigin->taintsCanvas(response().url()); 690 return !securityOrigin->taintsCanvas(response().url());
686 } 691 }
687 692
688 } // namespace blink 693 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698