Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3580)

Unified Diff: chrome/browser/ssl/chrome_security_state_model_client.h

Issue 2499243002: Record time to navigation/tab-closed after HTTP-bad warning (Closed)
Patch Set: fix test Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/chrome_security_state_model_client.h
diff --git a/chrome/browser/ssl/chrome_security_state_model_client.h b/chrome/browser/ssl/chrome_security_state_model_client.h
index 471ace912fbca302dc854893b45ea5686bb843c3..561722cb73a3fc248aec2c1dc2c4b47f3022c49e 100644
--- a/chrome/browser/ssl/chrome_security_state_model_client.h
+++ b/chrome/browser/ssl/chrome_security_state_model_client.h
@@ -37,8 +37,11 @@ class ChromeSecurityStateModelClient
void VisibleSecurityStateChanged();
// content::WebContentsObserver:
+ void DidStartNavigation(
+ content::NavigationHandle* navigation_handle) override;
void DidFinishNavigation(
content::NavigationHandle* navigation_handle) override;
+ void WebContentsDestroyed() override;
// Returns the SecurityStyle that should be applied to a WebContents
// with the given |security_info|. Populates
@@ -67,6 +70,13 @@ class ChromeSecurityStateModelClient
// navigation.
bool logged_http_warning_on_current_navigation_;
+ // The time that a console or omnibox warning was shown for insecure
+ // HTTP pages that contain password or credit card fields. This is set
+ // at most once per main-frame navigation (the first that an HTTP
+ // warning triggers on that navigation) and is used for UMA
+ // histogramming.
+ base::Time time_of_http_warning_on_current_navigation_;
+
DISALLOW_COPY_AND_ASSIGN(ChromeSecurityStateModelClient);
};

Powered by Google App Engine
This is Rietveld 408576698