Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2499173002: Android: Create ScreenInfo for the right display (Closed)

Created:
4 years, 1 month ago by Tima Vaisburd
Modified:
4 years, 1 month ago
Reviewers:
Ted C, boliu
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: Create ScreenInfo for the right display Since API 17 Android can have multiple displays. This CL creates ScreenInfo object for the display that holds the view, and not for the primary display as before. BUG=625089 Committed: https://crrev.com/49d4682679e71d1863b589b29933d9d0f5051059 Cr-Commit-Position: refs/heads/master@{#432203}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M content/browser/web_contents/web_contents_view_android.cc View 1 3 chunks +17 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Tima Vaisburd
PTAL.
4 years, 1 month ago (2016-11-14 20:12:59 UTC) #2
boliu
lgtm
4 years, 1 month ago (2016-11-14 20:47:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2499173002/60001
4 years, 1 month ago (2016-11-15 17:09:44 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 1 month ago (2016-11-15 17:15:35 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 17:31:50 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/49d4682679e71d1863b589b29933d9d0f5051059
Cr-Commit-Position: refs/heads/master@{#432203}

Powered by Google App Engine
This is Rietveld 408576698