Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2499143003: Nits in pdfium_test (Closed)

Created:
4 years, 1 month ago by npm
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix some nits in pdfium_test Fixed a couple of nits: - Renaming variables with correct format. - Add comments regarding the fact that pages are 0-based. Committed: https://pdfium.googlesource.com/pdfium/+/fa20cd5676065693cf7c575e247a13eb688cc924

Patch Set 1 #

Patch Set 2 : More #

Total comments: 2

Patch Set 3 : Fix tests, comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -51 lines) Patch
M samples/pdfium_test.cc View 1 2 13 chunks +52 lines, -51 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
npm
PTAL
4 years, 1 month ago (2016-11-14 20:47:06 UTC) #3
dsinclair
lgtm w/ nit https://codereview.chromium.org/2499143003/diff/20001/samples/pdfium_test.cc File samples/pdfium_test.cc (right): https://codereview.chromium.org/2499143003/diff/20001/samples/pdfium_test.cc#newcode506 samples/pdfium_test.cc:506: FPDF_BOOL Is_Data_Avail(FX_FILEAVAIL* p_this, size_t offset, size_t ...
4 years, 1 month ago (2016-11-14 20:57:20 UTC) #4
npm
https://codereview.chromium.org/2499143003/diff/20001/samples/pdfium_test.cc File samples/pdfium_test.cc (right): https://codereview.chromium.org/2499143003/diff/20001/samples/pdfium_test.cc#newcode506 samples/pdfium_test.cc:506: FPDF_BOOL Is_Data_Avail(FX_FILEAVAIL* p_this, size_t offset, size_t size) { On ...
4 years, 1 month ago (2016-11-14 21:01:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2499143003/30001
4 years, 1 month ago (2016-11-14 21:01:23 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 21:33:45 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:30001) as
https://pdfium.googlesource.com/pdfium/+/fa20cd5676065693cf7c575e247a13eb688c...

Powered by Google App Engine
This is Rietveld 408576698