Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 249913002: FIDO U2F component extension (Closed)

Created:
6 years, 8 months ago by Arnar Birgisson
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org, shah_chromium.org, samsrinivas_google.com, juanlang (chromium.org), mschilder1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

FIDO U2F (Universal 2nd factor) component extension NOTRY=true BUG=364678 TBR=miket Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266655

Patch Set 1 #

Patch Set 2 : Removes a comment that confuses presubmit license scanners #

Patch Set 3 : Add license header #

Patch Set 4 : Merge with HEAD #

Patch Set 5 : Merge with HEAD #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6401 lines, -3 lines) Patch
M chrome/browser/browser_resources.grd View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/component_loader.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/component_extension_resources.grd View 1 1 chunk +27 lines, -0 lines 0 comments Download
A chrome/browser/resources/cryptotoken/b64.js View 1 2 1 chunk +89 lines, -0 lines 0 comments Download
A chrome/browser/resources/cryptotoken/background.js View 1 2 1 chunk +85 lines, -0 lines 0 comments Download
A chrome/browser/resources/cryptotoken/closeable.js View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A chrome/browser/resources/cryptotoken/countdown.js View 1 2 1 chunk +125 lines, -0 lines 0 comments Download
A chrome/browser/resources/cryptotoken/devicestatuscodes.js View 1 2 1 chunk +51 lines, -0 lines 0 comments Download
A chrome/browser/resources/cryptotoken/enroller.js View 1 2 1 chunk +570 lines, -0 lines 0 comments Download
A chrome/browser/resources/cryptotoken/enrollhelper.js View 1 2 1 chunk +53 lines, -0 lines 0 comments Download
A chrome/browser/resources/cryptotoken/gnubbies.js View 1 2 1 chunk +313 lines, -0 lines 0 comments Download
A chrome/browser/resources/cryptotoken/gnubby.js View 1 2 1 chunk +627 lines, -0 lines 0 comments Download
A chrome/browser/resources/cryptotoken/gnubby-u2f.js View 1 2 1 chunk +88 lines, -0 lines 0 comments Download
A chrome/browser/resources/cryptotoken/gnubbycodetypes.js View 1 2 1 chunk +89 lines, -0 lines 0 comments Download
A chrome/browser/resources/cryptotoken/gnubbyfactory.js View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
A chrome/browser/resources/cryptotoken/gnubbymsgtypes.js View 1 2 1 chunk +46 lines, -0 lines 0 comments Download
A chrome/browser/resources/cryptotoken/llgnubby.js View 1 2 1 chunk +85 lines, -0 lines 0 comments Download
A chrome/browser/resources/cryptotoken/llhidgnubby.js View 1 2 1 chunk +458 lines, -0 lines 0 comments Download
A chrome/browser/resources/cryptotoken/llusbgnubby.js View 1 2 1 chunk +480 lines, -0 lines 0 comments Download
A chrome/browser/resources/cryptotoken/manifest.json View 1 chunk +58 lines, -0 lines 0 comments Download
A chrome/browser/resources/cryptotoken/multiplesigner.js View 1 2 1 chunk +276 lines, -0 lines 0 comments Download
A chrome/browser/resources/cryptotoken/requestqueue.js View 1 2 1 chunk +181 lines, -0 lines 0 comments Download
A chrome/browser/resources/cryptotoken/sha256.js View 1 2 1 chunk +156 lines, -0 lines 0 comments Download
A chrome/browser/resources/cryptotoken/signer.js View 1 2 1 chunk +626 lines, -0 lines 0 comments Download
A chrome/browser/resources/cryptotoken/signhelper.js View 1 2 1 chunk +49 lines, -0 lines 0 comments Download
A chrome/browser/resources/cryptotoken/singlesigner.js View 1 2 1 chunk +434 lines, -0 lines 0 comments Download
A chrome/browser/resources/cryptotoken/usbenrollhelper.js View 1 2 1 chunk +442 lines, -0 lines 0 comments Download
A chrome/browser/resources/cryptotoken/usbgnubbyfactory.js View 1 2 1 chunk +46 lines, -0 lines 0 comments Download
A chrome/browser/resources/cryptotoken/usbsignhelper.js View 1 2 1 chunk +344 lines, -0 lines 0 comments Download
A chrome/browser/resources/cryptotoken/util.js View 1 2 1 chunk +157 lines, -0 lines 0 comments Download
A chrome/browser/resources/cryptotoken/webrequest.js View 1 2 1 chunk +385 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 2 3 4 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 27 (0 generated)
xiyuan
LGTM A couple of more owners: miket@ for extensions/* sky@ for browser_resources.grd
6 years, 8 months ago (2014-04-24 18:23:10 UTC) #1
sky
LGTM
6 years, 8 months ago (2014-04-24 19:12:01 UTC) #2
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-04-24 20:59:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arnarb@chromium.org/249913002/1
6 years, 8 months ago (2014-04-24 21:14:27 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 22:44:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-24 22:44:45 UTC) #6
Ken Rockot(use gerrit already)
On 2014/04/24 22:44:45, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 8 months ago (2014-04-25 01:40:31 UTC) #7
Arnar Birgisson
The CQ bit was checked by arnarb@chromium.org
6 years, 8 months ago (2014-04-25 08:00:51 UTC) #8
Arnar Birgisson
The CQ bit was unchecked by arnarb@chromium.org
6 years, 8 months ago (2014-04-25 08:00:52 UTC) #9
Arnar Birgisson
The CQ bit was checked by arnarb@chromium.org
6 years, 8 months ago (2014-04-25 17:05:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arnarb@chromium.org/249913002/20001
6 years, 8 months ago (2014-04-25 21:42:27 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 22:33:50 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-25 22:33:51 UTC) #13
Arnar Birgisson
The CQ bit was checked by arnarb@chromium.org
6 years, 7 months ago (2014-04-28 16:21:59 UTC) #14
Arnar Birgisson
The CQ bit was unchecked by arnarb@chromium.org
6 years, 7 months ago (2014-04-28 16:22:02 UTC) #15
Arnar Birgisson
The CQ bit was checked by arnarb@chromium.org
6 years, 7 months ago (2014-04-28 16:22:07 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arnarb@chromium.org/249913002/40001
6 years, 7 months ago (2014-04-28 16:22:15 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 16:22:49 UTC) #18
commit-bot: I haz the power
Failed to apply patch for chrome/common/extensions/api/_permission_features.json: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 7 months ago (2014-04-28 16:22:50 UTC) #19
Arnar Birgisson
The CQ bit was unchecked by arnarb@chromium.org
6 years, 7 months ago (2014-04-28 16:22:55 UTC) #20
xiyuan
The CQ bit was checked by xiyuan@chromium.org
6 years, 7 months ago (2014-04-28 20:16:11 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arnarb@chromium.org/249913002/60001
6 years, 7 months ago (2014-04-28 20:17:27 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 20:17:43 UTC) #23
commit-bot: I haz the power
Failed to apply patch for chrome/common/extensions/api/_permission_features.json: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 7 months ago (2014-04-28 20:17:44 UTC) #24
Arnar Birgisson
The CQ bit was checked by arnarb@chromium.org
6 years, 7 months ago (2014-04-28 21:00:08 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arnarb@chromium.org/249913002/80001
6 years, 7 months ago (2014-04-28 21:01:17 UTC) #26
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 21:03:25 UTC) #27
Message was sent while issue was closed.
Change committed as 266655

Powered by Google App Engine
This is Rietveld 408576698