Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2499093002: Fix Guest Mode errors in MD Settings by using the incognito context. (Closed)

Created:
4 years, 1 month ago by hcarmona
Modified:
4 years, 1 month ago
Reviewers:
stevenjb
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Guest Mode errors in MD Settings by using the incognito context. BUG=654588 Committed: https://crrev.com/09a6d19d7bf0552dfc879828014fefd68fccdef2 Cr-Commit-Position: refs/heads/master@{#432544}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/browser/extensions/api/settings_private/settings_private_delegate_factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/settings_private/settings_private_delegate_factory.cc View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
hcarmona
PTAL
4 years, 1 month ago (2016-11-14 18:44:16 UTC) #7
stevenjb
Thanks for tracking this down! Sorry I wasn't more helpful. LGTM
4 years, 1 month ago (2016-11-15 23:01:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2499093002/1
4 years, 1 month ago (2016-11-16 15:05:11 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 17:44:24 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 17:49:45 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09a6d19d7bf0552dfc879828014fefd68fccdef2
Cr-Commit-Position: refs/heads/master@{#432544}

Powered by Google App Engine
This is Rietveld 408576698