Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: net/cert/cert_verify_proc_nss.cc

Issue 2499083003: Mac EV verification using Chrome methods rather than OS methods. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/cert_verify_proc_mac.cc ('k') | net/cert/ev_root_ca_metadata.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/cert_verify_proc_nss.cc
diff --git a/net/cert/cert_verify_proc_nss.cc b/net/cert/cert_verify_proc_nss.cc
index 673ec29a4ca59cf388d222614978082b573dc1de..1ac27cb48efb8d10c4c0d88eeffcb04e76b622da 100644
--- a/net/cert/cert_verify_proc_nss.cc
+++ b/net/cert/cert_verify_proc_nss.cc
@@ -282,12 +282,12 @@ CRLSetResult CheckRevocationWithCRLSet(const CERTCertList* cert_list,
if (root)
certs.push_back(root);
- // error is set to true if any errors are found. It causes such chains to be
- // considered as not covered.
+ // Set to true if any errors are found, which will cause such chains to not be
+ // treated as covered by the CRLSet.
bool error = false;
- // last_covered is set to the coverage state of the previous certificate. The
- // certificates are iterated over backwards thus, after the iteration,
- // |last_covered| contains the coverage state of the leaf certificate.
+ // Set to the coverage state of the previous certificate. As the certificates
+ // are iterated over from root to leaf, at the end of the iteration, this
+ // indicates the coverage state of the leaf certificate.
bool last_covered = false;
// We iterate from the root certificate down to the leaf, keeping track of
« no previous file with comments | « net/cert/cert_verify_proc_mac.cc ('k') | net/cert/ev_root_ca_metadata.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698