Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1064)

Issue 2499083003: Mac EV verification using Chrome methods rather than OS methods. (Closed)

Created:
4 years, 1 month ago by mattm
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Mac EV verification using Chrome methods rather than OS methods. Previously we were using some internal/private Mac OS APIs to get the results of OS EV checking, and those APIs stopped providing results on Sierra when we stopped passing the hostname to the OS verification (see crbug/621684). Additionally, it was impossible to unittest the old implementation. The new method is similar to what we do on other platforms, does not depend on OS handling, and can be unittested. Due to OS API limitations, the new method will be less efficient, but that additional inefficiency is limited to sites with EV certs. BUG=655612 Review-Url: https://codereview.chromium.org/2456523003 Cr-Commit-Position: refs/heads/master@{#431367} (cherry picked from commit 1a282f54af2ea79cf9aa0b78234e3b4053b4d73b) Committed: https://chromium.googlesource.com/chromium/src/+/945b76c48334c49d343cd43139418a3ef2298e1b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+449 lines, -156 lines) Patch
M chrome/browser/ui/certificate_viewer_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/cert_verify_proc_mac.cc View 18 chunks +261 lines, -87 lines 0 comments Download
M net/cert/cert_verify_proc_nss.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M net/cert/ev_root_ca_metadata.h View 3 chunks +15 lines, -1 line 0 comments Download
M net/cert/ev_root_ca_metadata.cc View 3 chunks +79 lines, -1 line 0 comments Download
M net/cert/ev_root_ca_metadata_unittest.cc View 7 chunks +18 lines, -7 lines 0 comments Download
M net/cert/x509_util_mac.h View 1 chunk +2 lines, -9 lines 0 comments Download
M net/cert/x509_util_mac.cc View 4 chunks +61 lines, -38 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mattm
4 years, 1 month ago (2016-11-14 23:00:05 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
945b76c48334c49d343cd43139418a3ef2298e1b.

Powered by Google App Engine
This is Rietveld 408576698