Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(851)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2499053003: Simplify RenderFrameImpl::ResolveOpener() (Closed)
Patch Set: Rebase. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | content/renderer/render_frame_proxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 4b9d528fb5fff49c29d3bedef9a7eb16b1869677..a24c5cf2d23bfbe0f08557c66d13d1bdbfcb8b5c 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -977,7 +977,7 @@ void RenderFrameImpl::CreateFrame(
replicated_state.sandbox_flags, render_frame,
previous_sibling_web_frame,
frame_owner_properties.ToWebFrameOwnerProperties(),
- ResolveOpener(opener_routing_id, nullptr));
+ ResolveOpener(opener_routing_id));
// The RenderFrame is created and inserted into the frame tree in the above
// call to createLocalChild.
@@ -1038,11 +1038,7 @@ void RenderFrameImpl::InstallCreateHook(
}
// static
-blink::WebFrame* RenderFrameImpl::ResolveOpener(int opener_frame_routing_id,
- int* opener_view_routing_id) {
- if (opener_view_routing_id)
- *opener_view_routing_id = MSG_ROUTING_NONE;
-
+blink::WebFrame* RenderFrameImpl::ResolveOpener(int opener_frame_routing_id) {
if (opener_frame_routing_id == MSG_ROUTING_NONE)
return nullptr;
@@ -1050,20 +1046,13 @@ blink::WebFrame* RenderFrameImpl::ResolveOpener(int opener_frame_routing_id,
// RenderFrame, so need to check both.
RenderFrameProxy* opener_proxy =
RenderFrameProxy::FromRoutingID(opener_frame_routing_id);
- if (opener_proxy) {
- if (opener_view_routing_id)
- *opener_view_routing_id = opener_proxy->render_view()->GetRoutingID();
-
+ if (opener_proxy)
return opener_proxy->web_frame();
- }
RenderFrameImpl* opener_frame =
RenderFrameImpl::FromRoutingID(opener_frame_routing_id);
- if (opener_frame) {
- if (opener_view_routing_id)
- *opener_view_routing_id = opener_frame->render_view()->GetRoutingID();
+ if (opener_frame)
return opener_frame->GetWebFrame();
- }
return nullptr;
}
@@ -2189,7 +2178,7 @@ void RenderFrameImpl::OnSnapshotAccessibilityTree(int callback_id) {
}
void RenderFrameImpl::OnUpdateOpener(int opener_routing_id) {
- WebFrame* opener = ResolveOpener(opener_routing_id, nullptr);
+ WebFrame* opener = ResolveOpener(opener_routing_id);
frame_->setOpener(opener);
}
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | content/renderer/render_frame_proxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698