Issue 2498983006: Remove pkg/pub_cache from pkg/third_party

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2498983006: Remove pkg/pub_cache from pkg/third_party (Closed)

Created:
4 years, 1 month ago by kevmoo

Modified:
4 years, 1 month ago

Reviewers:
devoncarew, Bill Hesse

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Remove pkg/pub_cache from pkg/third_party R=devoncarew@google.com Committed: https://github.com/dart-lang/sdk/commit/cee0f585ad3de80d794ce0678b0cc7d0e2e669e0

Patch Set 1 #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	.packages	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	DEPS	View		2 chunks	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kevmoo

This does not appear to be used at all any more... Correct me if I'm ...

4 years, 1 month ago (2016-11-15 18:07:32 UTC) #2

devoncarew

lgtm I don't see any direct uses; not sure about transitive uses.

4 years, 1 month ago (2016-11-15 18:38:53 UTC) #3

kevmoo

Committed patchset #1 (id:1) manually as cee0f585ad3de80d794ce0678b0cc7d0e2e669e0 (presubmit successful).

4 years, 1 month ago (2016-11-15 18:47:07 UTC) #5

kevmoo

4 years, 1 month ago (2016-11-15 18:48:00 UTC) #6

Message was sent while issue was closed.

On 2016/11/15 18:38:53, devoncarew wrote:
> lgtm
> 
> I don't see any direct uses; not sure about transitive uses.

I checked package dependencies – unless someone is omitting things in their
pubspec

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages