ReadableStream and WritableStream share strings

ReadableStream and WritableStream use some common string
constants. Share them to avoid duplication.

BUG=

Committed: https://crrev.com/ef448f0b40803fb6ef2d79211148d9075bd9dfa2
Cr-Commit-Position: refs/heads/master@{#436885}

[Adam Rice, 2016-11-14 10:05:41]

ricea@chromium.org changed reviewers:
+ domenic@chromium.org

[Adam Rice, 2016-11-14 10:05:41]

domenic, what do you think?

[Adam Rice, 2016-11-14 10:09:18]

Description was changed from

==========
ReadableStream and WritableStream use some common string
constants. Share them to avoid duplication.

BUG=
==========

to

==========
ReadableStream and WritableStream use some common string
constants. Share them to avoid duplication.

BUG=
==========

[domenic, 2016-11-14 17:59:53]

LGTM. Nice solution to the dependencies issue.

You might want to consider a lowercase filename since it's not named after a
class but I'm not sure what the protocol is there.

[Adam Rice, 2016-11-15 02:01:51]

ricea@chromium.org changed reviewers:
+ yhirano@chromium.org

[Adam Rice, 2016-11-15 02:01:52]

+yhirano Please let me know what you think about the lowercase vs. CamelCase
filename issue.

[yhirano, 2016-11-15 03:09:23]

On 2016/11/15 02:01:52, Adam Rice wrote:
> +yhirano Please let me know what you think about the lowercase vs. CamelCase
> filename issue.

I think being consistent is good. +1 for CamelCase.

By the way, the constants are shared among all v8 extra scripts, right? For
example, "errInvalidSize" sounds like a very general error but its contents is
specific to streams. Also, for genuine generic ones, such as
errIllegalInvocation, I'm not sure if it should be placed on this directory.

[Adam Rice, 2016-11-15 04:13:22]

On 2016/11/15 03:09:23, yhirano wrote:
> By the way, the constants are shared among all v8 extra scripts, right? For
> example, "errInvalidSize" sounds like a very general error but its contents is
> specific to streams. Also, for genuine generic ones, such as
> errIllegalInvocation, I'm not sure if it should be placed on this directory.

I have namespaced the constants. PTAL.

[yhirano, 2016-11-15 05:29:07]

On 2016/11/15 04:13:22, Adam Rice wrote:
> On 2016/11/15 03:09:23, yhirano wrote:
> > By the way, the constants are shared among all v8 extra scripts, right? For
> > example, "errInvalidSize" sounds like a very general error but its contents
is
> > specific to streams. Also, for genuine generic ones, such as
> > errIllegalInvocation, I'm not sure if it should be placed on this directory.
> 
> I have namespaced the constants. PTAL.

lgtm

[Adam Rice, 2016-11-15 05:42:08]

ricea@chromium.org changed reviewers:
+ brettw@chromium.org

[Adam Rice, 2016-11-15 05:42:09]

+brettw for v8.gni

[brettw, 2016-11-16 21:32:13]

https://codereview.chromium.org/2498983002/diff/20001/build_overrides/v8.gni
File build_overrides/v8.gni (right):

https://codereview.chromium.org/2498983002/diff/20001/build_overrides/v8.gni#...
build_overrides/v8.gni:15: v8_extras_dependencies =
Is this variable needed outside of this file? I don't see any reference to it in
v8.gni. Same with v8_extras.

If you want local variables that aren't exported, you can precede them with an
underscore. But I don't understand why this file is separated out from the list
below in the first place. Can you clarify?

[Adam Rice, 2016-11-17 06:32:51]

https://codereview.chromium.org/2498983002/diff/20001/build_overrides/v8.gni
File build_overrides/v8.gni (right):

https://codereview.chromium.org/2498983002/diff/20001/build_overrides/v8.gni#...
build_overrides/v8.gni:15: v8_extras_dependencies =
On 2016/11/16 21:32:12, brettw (ping on IM after 24h) wrote:
> Is this variable needed outside of this file? I don't see any reference to it
in
> v8.gni. Same with v8_extras.
> 
> If you want local variables that aren't exported, you can precede them with an
> underscore. But I don't understand why this file is separated out from the
list
> below in the first place. Can you clarify?

Sorry for making you look. I have added the underscore prefix to those
variables.

Dependencies need to be executed first. Since relying on sort order would be
fragile, I split out CommonStrings.js into a separate variable. I've added a
comment to clarify.

I plan to add CommonOperations.js in another CL.

[brettw, 2016-12-06 17:37:07]

lgtm

[Adam Rice, 2016-12-07 02:44:32]

The CQ bit was checked by ricea@chromium.org

[Adam Rice, 2016-12-07 02:44:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
domenic@chromium.org, yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2498983002/#ps40001
(title: "Prefix local variables with an underscore")

[commit-bot: I haz the power, 2016-12-07 02:45:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 02:47:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 02:47:51]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Adam Rice, 2016-12-07 03:58:42]

The CQ bit was checked by ricea@chromium.org

[Adam Rice, 2016-12-07 03:58:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
domenic@chromium.org, yhirano@chromium.org, brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2498983002/#ps60001
(title: "Rebase to fix patch errors and fix typo")

[commit-bot: I haz the power, 2016-12-07 03:58:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 05:20:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 05:20:28]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Adam Rice, 2016-12-07 05:40:38]

The CQ bit was checked by ricea@chromium.org

[commit-bot: I haz the power, 2016-12-07 05:40:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 07:12:57]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481089238824830,
"parent_rev": "f888941c5b004be81dc7ba4592060df764ac99c0", "commit_rev":
"dce6bfaedee9644102d4ed74c261dfdbff0716d0"}

[commit-bot: I haz the power, 2016-12-07 07:13:24]

Description was changed from

==========
ReadableStream and WritableStream use some common string
constants. Share them to avoid duplication.

BUG=
==========

to

==========
ReadableStream and WritableStream use some common string
constants. Share them to avoid duplication.

BUG=
==========

[commit-bot: I haz the power, 2016-12-07 07:13:25]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-07 07:14:44]

Description was changed from

==========
ReadableStream and WritableStream use some common string
constants. Share them to avoid duplication.

BUG=
==========

to

==========
ReadableStream and WritableStream use some common string
constants. Share them to avoid duplication.

BUG=

Committed: https://crrev.com/ef448f0b40803fb6ef2d79211148d9075bd9dfa2
Cr-Commit-Position: refs/heads/master@{#436885}
==========

[commit-bot: I haz the power, 2016-12-07 07:14:45]

Patchset 4 (id:??) landed as
https://crrev.com/ef448f0b40803fb6ef2d79211148d9075bd9dfa2
Cr-Commit-Position: refs/heads/master@{#436885}