Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2498973002: Merged: Squashed multiple commits. (Closed)

Created:
4 years, 1 month ago by Toon Verwaest
Modified:
4 years, 1 month ago
Reviewers:
Camillo Bruni
CC:
ulan, v8-merges_googlegroups.com, v8-reviews_googlegroups.com
Target Ref:
refs/pending/branch-heads/5.5
Project:
v8
Visibility:
Public.

Description

Merged: Squashed multiple commits. Merged: Add test for making private symbols non-enumerable Revision: 942604dfb2895cf0e56173b271e66804ff41478a Merged: Make private symbols non-enumerable Revision: 135b9f9360342089de151990a7bf61c31caa6f1f BUG=chromium:664411, chromium:664411 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=cbruni@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/551fc556ace04a947ee20bd1ab8df36e1bd3c963

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M src/lookup.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M src/property.h View 3 chunks +3 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/private.js View 1 chunk +2 lines, -2 lines 0 comments Download
A test/mjsunit/regress/regress-private-enumerable.js View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Toon Verwaest
4 years, 1 month ago (2016-11-14 09:50:57 UTC) #1
Toon Verwaest
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
4 years, 1 month ago (2016-11-14 09:50:58 UTC) #2
Camillo Bruni
lgtm
4 years, 1 month ago (2016-11-14 09:51:32 UTC) #3
Toon Verwaest
4 years, 1 month ago (2016-11-14 09:53:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
551fc556ace04a947ee20bd1ab8df36e1bd3c963.

Powered by Google App Engine
This is Rietveld 408576698