Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2498963002: Add test for making private symbols non-enumerable (Closed)

Created:
4 years, 1 month ago by Toon Verwaest
Modified:
4 years, 1 month ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add test for making private symbols non-enumerable BUG=chromium:664411 Committed: https://crrev.com/942604dfb2895cf0e56173b271e66804ff41478a Cr-Commit-Position: refs/heads/master@{#40950}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
A test/mjsunit/regress/regress-private-enumerable.js View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 1 month ago (2016-11-14 08:44:26 UTC) #2
Camillo Bruni
lgtm
4 years, 1 month ago (2016-11-14 08:45:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2498963002/1
4 years, 1 month ago (2016-11-14 08:47:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 09:16:20 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:31:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/942604dfb2895cf0e56173b271e66804ff41478a
Cr-Commit-Position: refs/heads/master@{#40950}

Powered by Google App Engine
This is Rietveld 408576698