Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

Issue 2498943002: (DONT COMMIT) Worker: Use the default stack size for workers (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
index f0b2d9fe1eee908340398a59079997a6aa4b58cf..abdddfd3910f330688efae5a208a4496113f10a5 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
@@ -488,22 +488,11 @@ static void messageHandlerInWorker(v8::Local<v8::Message> message,
perIsolateData->setReportingException(false);
}
-static const int kWorkerMaxStackSize = 500 * 1024;
-
-// This function uses a local stack variable to determine the isolate's stack
-// limit. AddressSanitizer may relocate that local variable to a fake stack,
-// which may lead to problems during JavaScript execution. Therefore we disable
-// AddressSanitizer for V8Initializer::initializeWorker().
-NO_SANITIZE_ADDRESS
void V8Initializer::initializeWorker(v8::Isolate* isolate) {
initializeV8Common(isolate);
isolate->AddMessageListener(messageHandlerInWorker);
isolate->SetFatalErrorHandler(reportFatalErrorInWorker);
-
- uint32_t here;
- isolate->SetStackLimit(reinterpret_cast<uintptr_t>(
- &here - kWorkerMaxStackSize / sizeof(uint32_t*)));
isolate->SetPromiseRejectCallback(promiseRejectHandlerInWorker);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698