Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3439)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

Issue 2498923002: Add UMA to measure how often pages don't receive any user input (Closed)
Patch Set: temporary variable Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
index 98b46899a0d8fe5feb3ffa75c4fad1f293efff0e..48b29f3e46a15c17062c48a6af0226e6f96ffb04 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
@@ -103,6 +103,12 @@ const char kBackgroundHistogramFirstContentfulPaint[] =
"PageLoad.PaintTiming.NavigationToFirstContentfulPaint.Background";
const char kHistogramFirstMeaningfulPaint[] =
"PageLoad.Experimental.PaintTiming.NavigationToFirstMeaningfulPaint";
+const char kHistogramFirstMeaningfulPaintNoUserInput[] =
+ "PageLoad.Experimental.PaintTiming.NavigationToFirstMeaningfulPaint."
+ "NoUserInput";
+const char kHistogramFirstMeaningfulPaintHadUserInput[] =
+ "PageLoad.Experimental.PaintTiming.NavigationToFirstMeaningfulPaint."
+ "HadUserInput";
const char kHistogramParseStartToFirstMeaningfulPaint[] =
"PageLoad.Experimental.PaintTiming.ParseStartToFirstMeaningfulPaint";
const char kHistogramParseStartToFirstContentfulPaint[] =
@@ -189,6 +195,8 @@ const char kHistogramFirstContentfulPaintUserInitiated[] =
const char kHistogramFirstMeaningfulPaintStatus[] =
"PageLoad.Experimental.PaintTiming.FirstMeaningfulPaintStatus";
+const char kHistogramFirstMeaningfulPaintSignalStatus[] =
+ "PageLoad.Experimental.PaintTiming.FirstMeaningfulPaintSignalStatus";
const char kHistogramFirstNonScrollInputAfterFirstPaint[] =
"PageLoad.InputTiming.NavigationToFirstNonScroll.AfterPaint";
@@ -565,6 +573,28 @@ void CorePageLoadMetricsObserver::RecordTimingHistograms(
internal::FIRST_MEANINGFUL_PAINT_DID_NOT_REACH_NETWORK_STABLE :
internal::FIRST_MEANINGFUL_PAINT_DID_NOT_REACH_FIRST_CONTENTFUL_PAINT);
}
+
+ enum FirstMeaningfulPaintSignalStatus {
+ HAD_USER_INPUT = 1 << 0,
+ NETWORK_STABLE = 1 << 1,
+ FIRST_MEANINGFUL_PAINT_SIGNAL_STATUS_LAST_ENTRY = 1 << 2
+ };
+ int signal_status =
+ (first_user_interaction_after_first_paint_.is_null() ?
+ 0 : HAD_USER_INPUT) +
+ (timing.first_meaningful_paint ? NETWORK_STABLE : 0);
+ UMA_HISTOGRAM_ENUMERATION(
+ internal::kHistogramFirstMeaningfulPaintSignalStatus,
+ signal_status, FIRST_MEANINGFUL_PAINT_SIGNAL_STATUS_LAST_ENTRY);
+ if (timing.first_meaningful_paint) {
+ if (first_user_interaction_after_first_paint_.is_null()) {
+ PAGE_LOAD_HISTOGRAM(internal::kHistogramFirstMeaningfulPaintNoUserInput,
+ timing.first_meaningful_paint.value());
+ } else {
+ PAGE_LOAD_HISTOGRAM(internal::kHistogramFirstMeaningfulPaintHadUserInput,
+ timing.first_meaningful_paint.value());
+ }
+ }
}
void CorePageLoadMetricsObserver::RecordRappor(
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698