Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 2498903002: Revert of Show the tutorial during OOBE (Closed)

Created:
4 years, 1 month ago by hiroshige
Modified:
4 years, 1 month ago
Reviewers:
dmazzoni, David Tseng
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Show the tutorial during OOBE (patchset #2 id:20001 of https://codereview.chromium.org/2497723002/ ) Reason for revert: Suspected to cause interactive_ui_tests failures on ChromeOS. BUG=664881 Original issue's description: > Show the tutorial during OOBE > > BUG= > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/fd046d62bd6bc1aed90edc479d198684fb707dda > Cr-Commit-Position: refs/heads/master@{#431804} TBR=dmazzoni@chromium.org,dtseng@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/e742b1f3da1d22b27eab549a616bcaf76eb3ad63 Cr-Commit-Position: refs/heads/master@{#431831}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
hiroshige
Created Revert of Show the tutorial during OOBE
4 years, 1 month ago (2016-11-14 04:58:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2498903002/1
4 years, 1 month ago (2016-11-14 04:58:36 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 04:59:39 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e742b1f3da1d22b27eab549a616bcaf76eb3ad63 Cr-Commit-Position: refs/heads/master@{#431831}
4 years, 1 month ago (2016-11-14 05:02:10 UTC) #7
David Tseng
4 years, 1 month ago (2016-11-14 16:44:47 UTC) #8
Message was sent while issue was closed.
Hi there, which test failed? I'm not seeing the build with the suspected
failure.

On Sun, Nov 13, 2016 at 9:02 PM, commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Patchset 1 (id:??) landed as
> https://crrev.com/e742b1f3da1d22b27eab549a616bcaf76eb3ad63
> Cr-Commit-Position: refs/heads/master@{#431831}
>
> https://codereview.chromium.org/2498903002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698