Source/core/inspector/InjectedScriptSource.js - Issue 24989007: Model each Dart library as its own ScriptState when devtools are enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InjectedScriptSource.js

Issue 24989007: Model each Dart library as its own ScriptState when devtools are enabled. (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/inspector/InjectedScriptSource.js

diff --git a/Source/core/inspector/InjectedScriptSource.js b/Source/core/inspector/InjectedScriptSource.js

index c2097012e8ce5bc1ae2d4e7fee3e11af91c20955..509381608fac316881c33f8f271d9f13caf967da 100644

--- a/Source/core/inspector/InjectedScriptSource.js

+++ b/Source/core/inspector/InjectedScriptSource.js

@@ -253,7 +253,8 @@ InjectedScript.prototype = {

_parseObjectId: function(objectId)

{

- return InjectedScriptHost.evaluate("(" + objectId + ")");

+ // FIXME: upstream the change from InjectedScriptHost.evaluate to JSON.parse.

+ return /** @type {Object} */ (JSON.parse(objectId));

/**

« no previous file with comments | « Source/bindings/v8/custom/V8InjectedScriptManager.cpp ('k') | Source/core/inspector/PageRuntimeAgent.h » ('j') | no next file with comments »