Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Issue 24989006: Disable recovery test for USE_SYSTEM_SQLITE. (Closed)

Created:
7 years, 2 months ago by Scott Hess - ex-Googler
Modified:
7 years, 2 months ago
CC:
chromium-reviews, browser-components-watch_chromium.org
Visibility:
Public.

Description

Disable recovery test for USE_SYSTEM_SQLITE. Detact and short-circuit rather than using an #ifdef because the test eventually needs to be adapted to actually test this case. I'm just not confident enough about possible edge cases to start deleting data. BUG=299677 TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227360

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M chrome/browser/history/thumbnail_database_unittest.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M sql/recovery.h View 1 chunk +9 lines, -0 lines 0 comments Download
M sql/recovery.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Scott Hess - ex-Googler
7 years, 2 months ago (2013-09-27 19:42:16 UTC) #1
rohitrao (ping after 24h)
Test changes LGTM, thanks for fixing this! Aside from unittests, the thumbnaildb code will probably ...
7 years, 2 months ago (2013-09-27 19:49:30 UTC) #2
Scott Hess - ex-Googler
On 2013/09/27 19:49:30, rohitrao wrote: > Aside from unittests, the thumbnaildb code will probably still ...
7 years, 2 months ago (2013-09-27 19:52:19 UTC) #3
Scott Hess - ex-Googler
I'm going to TBR to sky@, because I'm going OOT tomorrow and I don't want ...
7 years, 2 months ago (2013-09-27 19:53:48 UTC) #4
Scott Hess - ex-Googler
Oops, forgot to add Scott. Scott, I'm TBR'ing this minor change to the thumnail database ...
7 years, 2 months ago (2013-09-27 19:54:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/24989006/1
7 years, 2 months ago (2013-09-27 19:56:13 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=159771
7 years, 2 months ago (2013-09-27 22:07:22 UTC) #7
Scott Hess - ex-Googler
On 2013/09/27 22:07:22, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 2 months ago (2013-09-27 22:09:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/24989006/1
7 years, 2 months ago (2013-09-27 22:17:23 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=159831
7 years, 2 months ago (2013-09-27 23:42:34 UTC) #10
Scott Hess - ex-Googler
On 2013/09/27 23:42:34, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 2 months ago (2013-10-07 19:50:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/24989006/30001
7 years, 2 months ago (2013-10-07 19:51:03 UTC) #12
commit-bot: I haz the power
7 years, 2 months ago (2013-10-07 22:24:25 UTC) #13
Message was sent while issue was closed.
Change committed as 227360

Powered by Google App Engine
This is Rietveld 408576698