Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 24989003: Re-land "Add methods to enable configuration of ResourceConstraints based on limits derived at..." (Closed)

Created:
7 years, 2 months ago by rmcilroy
Modified:
7 years, 2 months ago
CC:
v8-dev
Visibility:
Public.

Description

Re-land "Add methods to enable configuration of ResourceConstraints based on limits derived at runtime." Adds ConfigureResourceConstraintsForCurrentPlatform and SetDefaultResourceConstraintsForCurrentPlatform which configure the heap based on the available physical memory, rather than hard-coding by platform as previous. This change also adds OS::TotalPhysicalMemory to platform.h. The re-land fix the performance regression caused by accidental change in default max young space size. BUG=292928 R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16983

Patch Set 1 #

Patch Set 2 : Reland original CL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -69 lines) Patch
M include/v8.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + include/v8-defaults.h View 1 1 chunk +20 lines, -21 lines 0 comments Download
M include/v8-testing.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/d8.cc View 1 3 chunks +3 lines, -0 lines 0 comments Download
A + src/defaults.cc View 1 1 chunk +38 lines, -24 lines 0 comments Download
M src/globals.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap.cc View 1 2 chunks +8 lines, -20 lines 0 comments Download
M src/platform.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/platform-posix.cc View 1 1 chunk +42 lines, -0 lines 0 comments Download
M src/platform-win32.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmcilroy
7 years, 2 months ago (2013-09-27 10:24:52 UTC) #1
Hannes Payer (out of office)
LGTM
7 years, 2 months ago (2013-09-27 10:45:51 UTC) #2
Hannes Payer (out of office)
7 years, 2 months ago (2013-09-27 10:53:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16983 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698