Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 24989002: Cleanup: Use base namespace in printing/. (Closed)

Created:
7 years, 2 months ago by Lei Zhang
Modified:
7 years, 2 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Cleanup: Use base namespace in printing/. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226174

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -47 lines) Patch
M printing/backend/print_backend.h View 1 chunk +1 line, -1 line 0 comments Download
M printing/backend/print_backend.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M printing/backend/win_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M printing/backend/win_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/print_dialog_gtk_interface.h View 1 chunk +1 line, -1 line 0 comments Download
M printing/print_settings.h View 3 chunks +9 lines, -9 lines 0 comments Download
M printing/print_settings.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M printing/print_settings_initializer.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M printing/print_settings_initializer_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/printed_document.h View 2 chunks +2 lines, -2 lines 0 comments Download
M printing/printed_document.cc View 1 chunk +8 lines, -6 lines 0 comments Download
M printing/printed_pages_source.h View 1 chunk +1 line, -1 line 0 comments Download
M printing/printing_context.h View 2 chunks +2 lines, -1 line 0 comments Download
M printing/printing_context_android.h View 1 chunk +1 line, -1 line 0 comments Download
M printing/printing_context_gtk.h View 2 chunks +2 lines, -2 lines 0 comments Download
M printing/printing_context_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/printing_context_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M printing/printing_context_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M printing/printing_context_no_system_dialog.h View 1 chunk +1 line, -1 line 0 comments Download
M printing/printing_context_no_system_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/printing_context_win.h View 1 chunk +1 line, -1 line 0 comments Download
M printing/printing_context_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
nothing exciting
7 years, 2 months ago (2013-09-27 08:05:56 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm
7 years, 2 months ago (2013-09-27 19:03:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/24989002/1
7 years, 2 months ago (2013-09-27 19:11:22 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=82550
7 years, 2 months ago (2013-09-27 21:22:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/24989002/1
7 years, 2 months ago (2013-09-30 23:38:09 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-01 07:19:15 UTC) #6
Message was sent while issue was closed. 
Change committed as 226174

Powered by Google App Engine
This is Rietveld 408576698