Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2498873004: Issue 27689. Fix incremental resolution with body modifiers changes. (Closed)

Created:
4 years, 1 month ago by scheglov
Modified:
4 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -0 lines) Patch
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 2 chunks +79 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/incremental_element_builder_test.dart View 1 chunk +37 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 1 month ago (2016-11-14 17:20:41 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2498873004/diff/1/pkg/analyzer/test/src/task/incremental_element_builder_test.dart File pkg/analyzer/test/src/task/incremental_element_builder_test.dart (right): https://codereview.chromium.org/2498873004/diff/1/pkg/analyzer/test/src/task/incremental_element_builder_test.dart#newcode714 pkg/analyzer/test/src/task/incremental_element_builder_test.dart:714: solo_test_classDelta_method_async_addStar() { Remove "solo_".
4 years, 1 month ago (2016-11-14 18:17:43 UTC) #2
scheglov
4 years, 1 month ago (2016-11-14 19:06:42 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b2c94a8a8987f70254232f8b6c837799d0cc3368 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698