Map deleted enum values to a sentinel value.

Map deleted enum values to a sentinel value.

Fixes #27802

BUG=
R=asiva@google.com, rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/f0f32a0e29ac93d6f3cb4e1ea655a4ac70d54791

[Cutch, 2016-11-14 17:42:36]

Description was changed from

==========
Map deleted enum values to a sentinel value.

Fixes #27802

BUG=
==========

to

==========
Map deleted enum values to a sentinel value.

Fixes #27802

BUG=
==========

[Cutch, 2016-11-14 17:42:37]

johnmccutchan@google.com changed reviewers:
+ asiva@google.com, rmacnak@google.com

[siva, 2016-11-14 22:18:23]

lgtm

https://codereview.chromium.org/2498863002/diff/1/runtime/vm/class_finalizer.cc
File runtime/vm/class_finalizer.cc (right):

https://codereview.chromium.org/2498863002/diff/1/runtime/vm/class_finalizer....
runtime/vm/class_finalizer.cc:2509: String& enum_ident = String::Handle();
A samll nit, the same handles created here field, enum_value, enum_ident etc.
could be used for the code above instead of creating a new set of handles
deleted_enum_field, deleted_enum_sentinel_value, deleted_enum_sentinel_name.

https://codereview.chromium.org/2498863002/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/2498863002/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:4876: Type::Handle(Z, Type::ArrayType()), cls.token_pos());
Type::Handle(Z, Type::ArrayType()) could be hoisted out from the two Field::New
calls.

Also we could hoist this above and use values_field handle for both cases.

[rmacnak, 2016-11-15 18:48:46]

lgtm

[Cutch, 2016-11-15 22:13:55]

https://codereview.chromium.org/2498863002/diff/1/runtime/vm/class_finalizer.cc
File runtime/vm/class_finalizer.cc (right):

https://codereview.chromium.org/2498863002/diff/1/runtime/vm/class_finalizer....
runtime/vm/class_finalizer.cc:2509: String& enum_ident = String::Handle();
On 2016/11/14 22:18:23, siva wrote:
> A samll nit, the same handles created here field, enum_value, enum_ident etc.
> could be used for the code above instead of creating a new set of handles
> deleted_enum_field, deleted_enum_sentinel_value, deleted_enum_sentinel_name.

Done.

https://codereview.chromium.org/2498863002/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/2498863002/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:4876: Type::Handle(Z, Type::ArrayType()), cls.token_pos());
On 2016/11/14 22:18:23, siva wrote:
> Type::Handle(Z, Type::ArrayType()) could be hoisted out from the two
Field::New
> calls.
> 
> Also we could hoist this above and use values_field handle for both cases.

Done.

[Cutch, 2016-11-15 22:15:41]

Description was changed from

==========
Map deleted enum values to a sentinel value.

Fixes #27802

BUG=
==========

to

==========
Map deleted enum values to a sentinel value.

Fixes #27802

BUG=
R=asiva@google.com, rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f0f32a0e29ac93d6f3cb4e1ea655a4ac70d54791
==========

[Cutch, 2016-11-15 22:15:42]

Committed patchset #2 (id:20001) manually as
f0f32a0e29ac93d6f3cb4e1ea655a4ac70d54791 (presubmit successful).