Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 249883004: fix x86 emulator for Android framework. (Closed)

Created:
6 years, 8 months ago by djsollen
Modified:
6 years, 8 months ago
Reviewers:
scroggo
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

fix x86 emulator for Android framework. The emulator is the one case where the android framework can be compiled without SSSE3 but be expected to run on a device with SSS3. In that case we just disable all SSSE3 options to be safe. Committed: http://code.google.com/p/skia/source/detail?r=14342

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M src/opts/opts_check_SSE2.cpp View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
djsollen
6 years, 8 months ago (2014-04-23 21:07:36 UTC) #1
scroggo
lgtm
6 years, 8 months ago (2014-04-23 21:11:16 UTC) #2
djsollen
The CQ bit was checked by djsollen@google.com
6 years, 8 months ago (2014-04-23 21:24:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/249883004/1
6 years, 8 months ago (2014-04-23 21:24:41 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-23 22:53:04 UTC) #5
Message was sent while issue was closed.
Change committed as 14342

Powered by Google App Engine
This is Rietveld 408576698