Issue 249883003: Dictionary::AtPut() handlified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 249883003: Dictionary::AtPut() handlified. (Closed)

Created:
6 years, 8 months ago by Igor Sheludko

Modified:
6 years, 8 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Dictionary::AtPut() handlified. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20935

Patch Set 1 #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -31 lines)			Patch
M	src/objects.h	View	3 chunks	+11 lines, -5 lines	0 comments	Download
M	src/objects.cc	View	5 chunks	+29 lines, -26 lines	1 comment	Download
M	src/objects-inl.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

lgtm. https://codereview.chromium.org/249883003/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/249883003/diff/1/src/objects.cc#newcode15955 src/objects.cc:15955: USE(k); Yeah this seems weird to have.

6 years, 8 months ago (2014-04-24 06:24:39 UTC) #2

Igor Sheludko

6 years, 8 months ago (2014-04-24 10:47:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20935 (presubmit successful).

Expand Messages | Collapse Messages