Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.h

Issue 2498823002: Paint invalidation of local attachment backgrounds (Closed)
Patch Set: Update test expectations Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.h
diff --git a/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.h b/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.h
index d98fb3bf0c921698e92479c73551db0d3955a9ef..61ca4f87a2244537a5e4d85c53209f8a44cb46e4 100644
--- a/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.h
+++ b/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.h
@@ -104,19 +104,6 @@ class ObjectPaintInvalidatorWithContext : public ObjectPaintInvalidator {
PaintInvalidationReason invalidatePaintIfNeededWithComputedReason(
PaintInvalidationReason);
- // This function tries to minimize the amount of invalidation generated by
- // invalidating the "difference" between |m_context.oldVisualRect| and
- // |m_context.newVisualRect|. This means invalidating the union of the
- // previous rectangles excluding their intersection. The use case is when an
- // element only requires a paint invalidation (which means that its content
- // didn't change) and its bounds changed but its location didn't. If we don't
- // meet the criteria for an incremental paint, the alternative is a full paint
- // invalidation. Returns true if any paint invalidation is done.
- bool incrementallyInvalidatePaint();
-
- private:
- void invalidateSelectionIfNeeded(PaintInvalidationReason);
-
// This function generates a full invalidation, which means invalidating both
// |oldVisualRect| and |newVisualRect|. This is the default choice when
// generating an invalidation, as it is always correct, albeit it may force
@@ -125,6 +112,9 @@ class ObjectPaintInvalidatorWithContext : public ObjectPaintInvalidator {
const LayoutRect& oldVisualRect,
const LayoutRect& newVisualRect);
+ private:
+ void invalidateSelectionIfNeeded(PaintInvalidationReason);
+
const PaintInvalidatorContext& m_context;
};

Powered by Google App Engine
This is Rietveld 408576698