Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Unified Diff: webkit/child/web_discardable_memory_impl.cc

Issue 24988003: Refactor DiscardableMemory for the upcoming DiscardableMemoryAllocator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix linux clang build Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/child/web_discardable_memory_impl.h ('k') | webkit/child/webkitplatformsupport_child_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/child/web_discardable_memory_impl.cc
diff --git a/webkit/child/web_discardable_memory_impl.cc b/webkit/child/web_discardable_memory_impl.cc
index 0e2663c00e9fccf184fdb74ced5593450c066de6..285f1b0de9a47dce20dedad2610ee2dca244ae96 100644
--- a/webkit/child/web_discardable_memory_impl.cc
+++ b/webkit/child/web_discardable_memory_impl.cc
@@ -6,14 +6,16 @@
namespace webkit_glue {
-WebDiscardableMemoryImpl::WebDiscardableMemoryImpl()
- : discardable_(new base::DiscardableMemory()) {
-}
-
WebDiscardableMemoryImpl::~WebDiscardableMemoryImpl() {}
-bool WebDiscardableMemoryImpl::InitializeAndLock(size_t size) {
- return discardable_->InitializeAndLock(size);
+// static
+scoped_ptr<WebDiscardableMemoryImpl>
+WebDiscardableMemoryImpl::CreateLockedMemory(size_t size) {
+ scoped_ptr<base::DiscardableMemory> memory(
+ base::DiscardableMemory::CreateLockedMemory(size));
+ if (!memory)
+ return scoped_ptr<WebDiscardableMemoryImpl>();
+ return make_scoped_ptr(new WebDiscardableMemoryImpl(memory.Pass()));
}
bool WebDiscardableMemoryImpl::lock() {
@@ -30,12 +32,17 @@ bool WebDiscardableMemoryImpl::lock() {
}
}
+void WebDiscardableMemoryImpl::unlock() {
+ discardable_->Unlock();
+}
+
void* WebDiscardableMemoryImpl::data() {
return discardable_->Memory();
}
-void WebDiscardableMemoryImpl::unlock() {
- discardable_->Unlock();
+WebDiscardableMemoryImpl::WebDiscardableMemoryImpl(
+ scoped_ptr<base::DiscardableMemory> memory)
+ : discardable_(memory.Pass()) {
}
} // namespace webkit_glue
« no previous file with comments | « webkit/child/web_discardable_memory_impl.h ('k') | webkit/child/webkitplatformsupport_child_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698