Refactor DiscardableMemory for the upcoming DiscardableMemoryAllocator.

base/memory/discardable_memory_android.h

Index: base/memory/discardable_memory_android.h
diff --git a/base/memory/discardable_memory_android.h b/base/memory/discardable_memory_android.h
new file mode 100644
index 0000000000000000000000000000000000000000..abaf7727d955a14d4114e8ee7a111c253bdbd576
--- /dev/null
+++ b/base/memory/discardable_memory_android.h
@@ -0,0 +1,31 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Please use discardable_memory.h since this is just an internal file providing
+// utility functions.
+
+#ifndef BASE_MEMORY_DISCARDABLE_MEMORY_ANDROID_H_
+#define BASE_MEMORY_DISCARDABLE_MEMORY_ANDROID_H_
+
+#include "base/basictypes.h"
+#include "base/memory/discardable_memory.h"
+
+namespace base {
+namespace internal {
+
+bool CreateAshmemRegion(const char* name, size_t size, int* fd, void** address);

[willchan no longer on Chromium, 2013/10/17 01:21:37]

BASE_EXPORT_PRIVATE all of these? Why are these even in the header file in the
first place? I don't see where they get used except in the .cc file, but I must
be missing something.

[Philippe, 2013/10/17 08:56:24]

This will be used by the allocator. I agree that this should not be exposed
before it's being used so I deleted this header file, moved these functions in
the .cc file to the anonymous namespace and will add the header back/move the
functions back to the internal namespace in the allocator CL.

+
+bool DeleteAshmemRegion(int fd, size_t size, void* address);
+
+LockDiscardableMemoryStatus LockAshmemRegion(int fd,
+                                             size_t off,
+                                             size_t size,
+                                             const void* address);
+
+bool UnlockAshmemRegion(int fd, size_t off, size_t size, const void* address);
+
+}  // namespace internal
+}  // namespace base
+
+#endif  // BASE_MEMORY_DISCARDABLE_MEMORY_ANDROID_H_