third_party/WebKit/LayoutTests/inspector/editor/php-highlighter.html - Issue 2498783002: DevTools: [Sources] Improve editor load time by optimizing setMimeType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/editor/php-highlighter.html

Issue 2498783002: DevTools: [Sources] Improve editor load time by optimizing setMimeType (Closed)

Patch Set: Remove unneeded if Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/editor/text-editor-token-at-position.html » ('j') | third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/editor/php-highlighter.html

diff --git a/third_party/WebKit/LayoutTests/inspector/editor/php-highlighter.html b/third_party/WebKit/LayoutTests/inspector/editor/php-highlighter.html

index 57e54a6ac586217afd676ec00d1265c443514f49..c70bcc28cf074b321b76b0f4286f8f845705c9c3 100644

--- a/third_party/WebKit/LayoutTests/inspector/editor/php-highlighter.html

+++ b/third_party/WebKit/LayoutTests/inspector/editor/php-highlighter.html

@@ -7,8 +7,8 @@ function test()

{

var mimeType = "text/x-php";

var textEditor = InspectorTest.createTestEditor();

- textEditor.setMimeType(mimeType).then(onModesLoaded);

+ InspectorTest.addSnifferPromise(SourceFrame.SourcesTextEditor.prototype, "rewriteMimeType").then(onModesLoaded);

+ textEditor.setMimeType(mimeType);

function onModesLoaded()

{

InspectorTest.addResult("Mode loaded: " + !!CodeMirror.mimeModes[mimeType]);