Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp

Issue 2498763002: Allow subsequence caching for SVG roots that have PaintLayers. (Closed)
Patch Set: none Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp b/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
index eea4ca3e7b43624d3f5d5a8380a852969219642a..a3b2ef5b3824f9df8e274247ed5e6a00d067b623 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
@@ -151,13 +151,15 @@ static bool shouldCreateSubsequence(const PaintLayer& paintLayer,
return false;
// Create subsequence for only stacking contexts whose painting are atomic.
- if (!paintLayer.stackingNode()->isStackingContext())
+ if (!paintLayer.stackingNode()->isStackingContext() &&
+ !paintLayer.layoutObject()->isSVGRoot())
wkorman 2016/11/12 00:05:51 Consider adding comment above this block re: why w
chrishtr 2016/11/12 00:15:20 Done.
return false;
// The layer doesn't have children. Subsequence caching is not worth because
// normally the actual painting will be cheap.
if (!PaintLayerStackingNodeIterator(*paintLayer.stackingNode(), AllChildren)
- .next())
+ .next() &&
+ !paintLayer.layoutObject()->isSVGRoot())
return false;
// When in FOUC-avoidance mode, don't cache any subsequences, to avoid having
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698