Allow subsequence caching for SVG roots that have PaintLayers.

third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/LayoutBoxModelObject.h"
 #include "core/layout/compositing/CompositedLayerMapping.h"
 #include "core/paint/PaintControllerPaintTest.h"
 #include "platform/graphics/GraphicsContext.h"
 #include "platform/testing/RuntimeEnabledFeaturesTestHelpers.h"
 
@@ skipping 179 matching lines @@
         TestDisplayItem(content1, backgroundType),
         TestDisplayItem(container1Layer, DisplayItem::kEndSubsequence),
         TestDisplayItem(container2Layer, DisplayItem::kSubsequence),
         TestDisplayItem(container2, backgroundType),
         TestDisplayItem(content2, backgroundType),
         TestDisplayItem(container2Layer, DisplayItem::kEndSubsequence),
         TestDisplayItem(htmlLayer, DisplayItem::kEndSubsequence));
   }
 }
 
+TEST_P(PaintLayerPainterTest, CachedSubsequenceForSVGRoot) {
+  setBodyInnerHTML(
+      "<svg id='svg' style='position: relative'>"
+      "  <rect id='rect' x='10' y='10' width='100' height='100' rx='15' "
+      "ry='15'/>"
+      "</svg>"
+      "<div id='div' style='position: relative; width: 50x; height: "
+      "50px'></div>");
+  document().view()->updateAllLifecyclePhases();
+
+  PaintLayer& htmlLayer =
+      *toLayoutBoxModelObject(document().documentElement()->layoutObject())
+           ->layer();
+  LayoutObject& svg = *document().getElementById("svg")->layoutObject();
+  PaintLayer& svgLayer = *toLayoutBoxModelObject(svg).layer();
+  LayoutObject& rect = *document().getElementById("rect")->layoutObject();
+  LayoutObject& div = *document().getElementById("div")->layoutObject();
+
+  DisplayItem::Type clipBoxBegin =
+      DisplayItem::paintPhaseToClipBoxType(PaintPhaseForeground);
+  DisplayItem::Type clipBoxEnd =
+      DisplayItem::clipTypeToEndClipType(clipBoxBegin);
+
+  if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
+    if (RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {
+      // SPv2 slips the clip box (see BoxClipper).
+      EXPECT_DISPLAY_LIST(
+          rootPaintController().getDisplayItemList(), 10,
+          TestDisplayItem(*layoutView().layer(), DisplayItem::kSubsequence),
+          TestDisplayItem(layoutView(), documentBackgroundType),
+          TestDisplayItem(htmlLayer, DisplayItem::kSubsequence),
+          TestDisplayItem(svgLayer, DisplayItem::kSubsequence),
+          TestDisplayItem(svg, DisplayItem::kBeginTransform),
+          TestDisplayItem(rect, foregroundType),
+          TestDisplayItem(svg, DisplayItem::kEndTransform),
+          TestDisplayItem(svgLayer, DisplayItem::kEndSubsequence),
+          TestDisplayItem(htmlLayer, DisplayItem::kEndSubsequence),
+          TestDisplayItem(*layoutView().layer(), DisplayItem::kEndSubsequence));
+    } else {
+      // SPv2 slips the clip box (see BoxClipper).
+      EXPECT_DISPLAY_LIST(
+          rootPaintController().getDisplayItemList(), 12,
+          TestDisplayItem(layoutView(),
+                          DisplayItem::kClipFrameToVisibleContentRect),
+          TestDisplayItem(*layoutView().layer(), DisplayItem::kSubsequence),
+          TestDisplayItem(layoutView(), documentBackgroundType),
+          TestDisplayItem(htmlLayer, DisplayItem::kSubsequence),
+          TestDisplayItem(svgLayer, DisplayItem::kSubsequence),
+          TestDisplayItem(svg, DisplayItem::kBeginTransform),
+          TestDisplayItem(rect, foregroundType),
+          TestDisplayItem(svg, DisplayItem::kEndTransform),
+          TestDisplayItem(svgLayer, DisplayItem::kEndSubsequence),
+          TestDisplayItem(htmlLayer, DisplayItem::kEndSubsequence),
+          TestDisplayItem(*layoutView().layer(), DisplayItem::kEndSubsequence),
+          TestDisplayItem(layoutView(),
+                          DisplayItem::clipTypeToEndClipType(
+                              DisplayItem::kClipFrameToVisibleContentRect)));
+    }
+  } else {
+    EXPECT_DISPLAY_LIST(
+        rootPaintController().getDisplayItemList(), 10,
+        TestDisplayItem(layoutView(), documentBackgroundType),
+        TestDisplayItem(htmlLayer, DisplayItem::kSubsequence),
+        TestDisplayItem(svgLayer, DisplayItem::kSubsequence),
+        TestDisplayItem(svg, clipBoxBegin),
+        TestDisplayItem(svg, DisplayItem::kBeginTransform),
+        TestDisplayItem(rect, foregroundType),
+        TestDisplayItem(svg, DisplayItem::kEndTransform),
+        TestDisplayItem(svg, clipBoxEnd),
+        TestDisplayItem(svgLayer, DisplayItem::kEndSubsequence),
+        TestDisplayItem(htmlLayer, DisplayItem::kEndSubsequence));
+  }
+
+  // Change the color of the div. This should not invalidate the subsequence
+  // for the SVG root.
+  toHTMLElement(div.node())
+      ->setAttribute(HTMLNames::styleAttr,
+                     "position: relative; width: 50x; height: 50px; "
+                     "background-color: green");
+  document().view()->updateAllLifecyclePhasesExceptPaint();
+  EXPECT_TRUE(paintWithoutCommit());
+
+  // Reuse of SVG and document background. 2 fewer with SPv2 enabled because
+  // clip display items don't appear in SPv2 display lists.
+  if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())
+    EXPECT_EQ(6, numCachedNewItems());
+  else
+    EXPECT_EQ(8, numCachedNewItems());
+
+  commit();
+
+  if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
+    if (RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {
+      EXPECT_DISPLAY_LIST(
+          rootPaintController().getDisplayItemList(), 11,
+          TestDisplayItem(*layoutView().layer(), DisplayItem::kSubsequence),
+          TestDisplayItem(layoutView(), documentBackgroundType),
+          TestDisplayItem(htmlLayer, DisplayItem::kSubsequence),
+          TestDisplayItem(svgLayer, DisplayItem::kSubsequence),
+          TestDisplayItem(svg, DisplayItem::kBeginTransform),
+          TestDisplayItem(rect, foregroundType),
+          TestDisplayItem(svg, DisplayItem::kEndTransform),
+          TestDisplayItem(svgLayer, DisplayItem::kEndSubsequence),
+          TestDisplayItem(div, backgroundType),
+          TestDisplayItem(htmlLayer, DisplayItem::kEndSubsequence),
+          TestDisplayItem(*layoutView().layer(), DisplayItem::kEndSubsequence));
+    } else {
+      EXPECT_DISPLAY_LIST(
+          rootPaintController().getDisplayItemList(), 13,
+          TestDisplayItem(layoutView(),
+                          DisplayItem::kClipFrameToVisibleContentRect),
+          TestDisplayItem(*layoutView().layer(), DisplayItem::kSubsequence),
+          TestDisplayItem(layoutView(), documentBackgroundType),
+          TestDisplayItem(htmlLayer, DisplayItem::kSubsequence),
+          TestDisplayItem(svgLayer, DisplayItem::kSubsequence),
+          TestDisplayItem(svg, DisplayItem::kBeginTransform),
+          TestDisplayItem(rect, foregroundType),
+          TestDisplayItem(svg, DisplayItem::kEndTransform),
+          TestDisplayItem(svgLayer, DisplayItem::kEndSubsequence),
+          TestDisplayItem(div, backgroundType),
+          TestDisplayItem(htmlLayer, DisplayItem::kEndSubsequence),
+          TestDisplayItem(*layoutView().layer(), DisplayItem::kEndSubsequence),
+          TestDisplayItem(layoutView(),
+                          DisplayItem::clipTypeToEndClipType(
+                              DisplayItem::kClipFrameToVisibleContentRect)));
+    }
+  } else {
+    EXPECT_DISPLAY_LIST(
+        rootPaintController().getDisplayItemList(), 11,
+        TestDisplayItem(layoutView(), documentBackgroundType),
+        TestDisplayItem(htmlLayer, DisplayItem::kSubsequence),
+        TestDisplayItem(svgLayer, DisplayItem::kSubsequence),
+        TestDisplayItem(svg, clipBoxBegin),
+        TestDisplayItem(svg, DisplayItem::kBeginTransform),
+        TestDisplayItem(rect, foregroundType),
+        TestDisplayItem(svg, DisplayItem::kEndTransform),
+        TestDisplayItem(svg, clipBoxEnd),
+        TestDisplayItem(svgLayer, DisplayItem::kEndSubsequence),
+        TestDisplayItem(div, backgroundType),
+        TestDisplayItem(htmlLayer, DisplayItem::kEndSubsequence),
+        TestDisplayItem(layoutView(),
+                        DisplayItem::clipTypeToEndClipType(
+                            DisplayItem::kClipFrameToVisibleContentRect)));
+  }
+}
+
 TEST_P(PaintLayerPainterTest, CachedSubsequenceOnInterestRectChange) {
   // TODO(wangxianzhu): SPv2 deals with interest rect differently, so disable
   // this test for SPv2 temporarily.
   if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())
     return;
 
   setBodyInnerHTML(
       "<div id='container1' style='position: relative; z-index: 1; width: "
       "200px; height: 200px; background-color: blue'>"
       "  <div id='content1' style='position: absolute; width: 100px; height: "
@@ skipping 642 matching lines @@
   EXPECT_FALSE(layer.needsPaintPhaseDescendantBlockBackgrounds());
 
   toHTMLElement(table.node())
       ->setAttribute(HTMLNames::styleAttr,
                      "position: relative; border-collapse: collapse");
   document().view()->updateAllLifecyclePhases();
   EXPECT_TRUE(layer.needsPaintPhaseDescendantBlockBackgrounds());
 }
 
 }  // namespace blink